Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error on input type missmatch (fix #459) #484

Closed
wants to merge 1 commit into from
Closed

Better error on input type missmatch (fix #459) #484

wants to merge 1 commit into from

Conversation

bambuchaAdm
Copy link

As instructed in #459 i made changes. I don't know if tests are in correct place - if need to be differ please tell me.

eemeli
eemeli requested changes Jul 2, 2023
View reviewed changes
Copy link
Owner

@eemeli eemeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't need a new error class, but a new error code for YAMLParseError, which also needs to be documented. Also, please run Prettier to fix the code style.

@eemeli
Copy link
Owner

eemeli commented Jun 2, 2024

Closing in favour of a1dc96f.

@eemeli eemeli closed this Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eemeli eemeli eemeli requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bambuchaAdm @eemeli