Address remaining Ref.Emit warnings in Mono.

Contributes to dotnet#45623
eerhardt · Dec 7, 2020 · 13f9933 · 13f9933
1 parent 301056d
commit 13f9933
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 18 deletions.
diff --git a/src/mono/netcore/System.Private.CoreLib/src/ILLink/ILLink.Suppressions.xml b/src/mono/netcore/System.Private.CoreLib/src/ILLink/ILLink.Suppressions.xml
diff --git a/...mono/netcore/System.Private.CoreLib/src/System/Reflection/Emit/MethodOnTypeBuilderInst.cs b/...mono/netcore/System.Private.CoreLib/src/System/Reflection/Emit/MethodOnTypeBuilderInst.cs
@@ -100,6 +100,9 @@ private static MethodInfo ExtractBaseMethod(MethodInfo info)
         }
 
         // Called from the runtime to return the corresponding finished MethodInfo object
+        [UnconditionalSuppressMessage("ReflectionAnalysis", "IL2060:MakeGenericMethod",
+            Justification = "MethodOnTypeBuilderInst is Reflection.Emit's underlying implementation of MakeGenericMethod. " +
+                "Callers of the outer calls to MakeGenericMethod will be warned as appropriate.")]
         internal MethodInfo RuntimeResolve()
         {
             Type type = instantiation.InternalResolve();

diff --git a/src/mono/netcore/System.Private.CoreLib/src/System/Reflection/Emit/TypeBuilder.Mono.cs b/src/mono/netcore/System.Private.CoreLib/src/System/Reflection/Emit/TypeBuilder.Mono.cs
@@ -910,6 +910,8 @@ private bool has_ctor_method()
             return this;
         }
 
+        [UnconditionalSuppressMessage("ReflectionAnalysis", "IL2074:UnrecognizedReflectionPattern",
+            Justification = "Linker doesn't analyze ResolveUserType but it's an identity function")]
         private void ResolveUserTypes()
         {
             parent = ResolveUserType(parent);
@@ -1615,7 +1617,7 @@ public FieldBuilder DefineUninitializedData(string name, int size, FieldAttribut
         public override int MetadataToken => 0x02000000 | table_idx;
 
         [UnconditionalSuppressMessage("ReflectionAnalysis", "IL2074:UnrecognizedReflectionPattern",
-            Justification = "Linker doesn't recongnize ResolveUserType")]
+            Justification = "Linker doesn't analyze ResolveUserType but it's an identity function")]
         public void SetParent([DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.All)] Type? parent)
         {
             check_not_created();