-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix all the things #100
Open
stefanpenner
wants to merge
48
commits into
master
Choose a base branch
from
fix-all-the-things
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix all the things #100
Changes from 1 commit
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
78e9b9d
[REFACTOR] stubs now gets imports provided via set, rather than extra…
stefanpenner eae97f3
first pass of import/export identifier mangling
stefanpenner c388ac6
more ember-cli 1.x related removals
stefanpenner b4e6a04
allow StubGenerator -> CachingBrowserify to overwrite output from app.
stefanpenner b0387a9
remove more ember-cli 1.x stuff
stefanpenner d29a10e
StubGenerator output needs to be merged into tree
stefanpenner 1532cac
resolve actual versions
stefanpenner 9a81644
refactor tests (split up concerns)
stefanpenner 71ab74f
Fixed test for multiple input rewrites.
nathanhammond cdf0067
add jshinting to tests
stefanpenner 831f464
fix hinting
stefanpenner ee94775
fixup spacing
stefanpenner d30025b
use chai-files
stefanpenner b3f7faa
tidy up test files
stefanpenner 75f48c1
more cleanup
stefanpenner 6548bfa
Add in Ember Addon boilerplate.
nathanhammond 0683633
Fix CI.
nathanhammond f02b3a5
Add in VS Code debug profile for mocha.
nathanhammond 8fa1b0d
Use string positions to handle replacement.
nathanhammond 2ef155c
Extract rewrite-imports.
nathanhammond 74ab985
Alphabetize package.json
nathanhammond b65c162
npm fixtures
nathanhammond a7f4b5d
Set up top-level addon fixtures.
nathanhammond 0850b99
Make sure caching-browserify (a legacy plugin) toStrings helpfully, s…
stefanpenner d25ff36
add a very simple/basic scenario (that works)
stefanpenner a60d9f9
remove unused file
stefanpenner e5f3e89
lazily require browserify, only injuring its load cost when used.
stefanpenner 1f44127
only include the part of lodash we use.
stefanpenner 47055a5
update dependency to be more accurate
stefanpenner 8f250bb
fix lodash usage
stefanpenner 555d137
update example to more closely match what works
stefanpenner f605a3b
cross platform setup script
stefanpenner 062f674
remove trailing whitespace
stefanpenner e3c8b59
update example to work with in-repo addons
stefanpenner 2c686a0
update symlink/junction hack to work in more cases
stefanpenner f3e0231
Rework tests, add reexports scenario.
nathanhammond 59004b2
Properly set on prepublish.
nathanhammond 69cc443
Revert "add a very simple/basic scenario (that works)"
nathanhammond 772c859
Structure for doing the right thing in the vendor hook.
nathanhammond 80b0caf
Merge pull request #106 from nathanhammond/fix-all-the-things
stefanpenner 0ef7aa4
Partial rewrite of preprocessor approach.
nathanhammond b6f11dc
Move away from postprocessTree.
nathanhammond 80597f7
Properly set basedir per target.
nathanhammond 0f5a959
Merge pull request #109 from nathanhammond/fix-all-the-things
nathanhammond 03c9c95
add comments, making it easier to understand where stuff is actually …
stefanpenner f5908b9
only rewrite if rewriting is required
stefanpenner a70c006
remove optimization for now. Bring back with tests.
stefanpenner e314119
Use the proper hook for setting up the registry.
nathanhammond File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to try comparing the imports object across runs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ya, i'll fix in the work im about todo.