Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes redundant check #95

Closed
wants to merge 1 commit into from
Closed

Removes redundant check #95

wants to merge 1 commit into from

Conversation

twokul
Copy link
Contributor

@twokul twokul commented Aug 7, 2016

Some of the child addons (the ones that consume ember-browserify) start breaking after upgrading to 2.7.0. This fixes failures.

@stefanpenner
Copy link
Collaborator

@ef4 / @asakusuma r?

@asakusuma
Copy link
Collaborator

@stefanpenner lgtm, but isn't this the same general approach as #93? And if so, does the same deduping question need to be answered?

@twokul
Copy link
Contributor Author

twokul commented Aug 8, 2016

@asakusuma I somehow missed that PR. I feel like deduping is a pandora's box and requires a different PR/conversation all together.

/cc @stefanpenner

@asakusuma
Copy link
Collaborator

@twokul I agree that this is a separate issue, but I defer to @stefanpenner since he raised the issue in the first place.

@twokul
Copy link
Contributor Author

twokul commented Aug 8, 2016

@asakusuma 👍 👌

@stefanpenner
Copy link
Collaborator

stefanpenner commented Aug 16, 2016

@twokul did you do the deeper investigation we discussed in-person.

We discovered that basically the scenario described most likely does not work in the first case, this merely prevents it from exploding but does not address the underlying issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants