speed up Meta instantiation #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6ms -> noise turns out there is no 0 cost abstraction in JS yet...
In one example this removes nearly 8% of gets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6ms -> noise
turns out there is no 0 cost abstraction in JS yet...
this is more or less the result after several independent runs.
This also seems to have pulled down GC cost, I suspect that context perserved by the
forEachfor_thiswas largely to blame for the later. With a for loop the perf was midway. So combination of both yielded a good win here. My test case over-all improved nicely, from always ~1050ms to always mid 950ms...