-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't compress git files in caravel and mgmt_core_wrapper repos #77
Conversation
@antonblanchard This pull request modifies 3 files. Is that what you intended? I think the main repo may have been updated after you created the branch. Maybe fetch upstream on github and then in your local repo
Maybe. |
It's some automated script that is getting applied to all of my PRs post creation:
|
Looking at this closer, I think the issue is the caravel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix for the Makefile
is proper, but please make sure that your pull request does not include changes to README.rst
(which overwrites a typo fix from Mitch) or manifest
(which is auto-generated).
make compress is trying to compress a large file in mgmt_core_wrapper .git dir.
5ed6f06
to
4486fbf
Compare
@RTimothyEdwards Thanks for the review, I've rebased and the other files are now not getting updated. FYI The issue is an automated script on pull request creation, and your recent commit just undid the typo: 8aafe0c#diff-7b3ed02bc73dc06b7db906cf97aa91dec2b2eb21f2d92bc5caa761df5bbc168fL155 |
@antonblanchard : There is some automatic script that changes the manifest but also changes the README.rst and so undermines any attempt to fix the typo in that file. . . It automatically puts the typo back in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Critically needed fix.
@jeffdi : Please merge this ASAP. Hopefully it does not cause conflicts with changes to the Makefile in other pull requests. |
make compress is trying to compress a large file in mgmt_core_wrapper .git dir.
make compress is trying to compress a large file in mgmt_core_wrapper
.git dir.