Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix upstream breakage due to missing docker mount #80

Merged
merged 1 commit into from
Apr 21, 2022
Merged

Fix upstream breakage due to missing docker mount #80

merged 1 commit into from
Apr 21, 2022

Conversation

antonblanchard
Copy link
Contributor

No description provided.

@antonblanchard
Copy link
Contributor Author

@RTimothyEdwards commit 7160044 ("Caravan top lvs (#67)") removed this mount which broke tape outs for me.

RTimothyEdwards
RTimothyEdwards approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@RTimothyEdwards RTimothyEdwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this appears to be needed and got broken when caravan top-level routing was done.

@RTimothyEdwards
Copy link
Contributor

@jeffdi : The caravan top level routing apparently broke a number of things in the repository, so when I pulled caravan_re-routing, several files ended up with errors. My subsequent pull request was not cherry-picked as I requested, so these errors ended up in the main branch. This pull request fixes one of the errors but I worry that there are others. At any rate, this needs to be merged ASAP.

@jeffdi jeffdi merged commit 562405a into efabless:main Apr 21, 2022
M0stafaRady pushed a commit that referenced this pull request Sep 30, 2022
@antonblanchard
Fix upstream breakage due to missing docker mount (#80)
2fc8c13
@RTimothyEdwards RTimothyEdwards added error Something isn't working flow Makefile or in-repository flow script changed labels Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RTimothyEdwards RTimothyEdwards RTimothyEdwards approved these changes

Assignees
No one assigned
Labels
error Something isn't working flow Makefile or in-repository flow script changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antonblanchard @RTimothyEdwards @jeffdi