Corrected the gpio_control_block to avoid potential floating signal driving an inverter #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
does not pass through an inverter, so that the input can remain unconnected. Rewired the existing implementation to use an alternative gate that has an inverting input so that the user_gpio_out signal can be left undriven when the GPIOs are in the management enable state. This is a simple logic refactoring and does not change the logic function. The manual rewiring has been confirmed by LVS, but at least one GL simulation should be run to confirm that the logic function remains the same as before.
jeffdi
approved these changes
Apr 25, 2022
antonblanchard
pushed a commit
to antonblanchard/caravel
that referenced
this pull request
Apr 27, 2022
fix make <block> running all make blocks
M0stafaRady
pushed a commit
that referenced
this pull request
Sep 30, 2022
does not pass through an inverter, so that the input can remain unconnected. Rewired the existing implementation to use an alternative gate that has an inverting input so that the user_gpio_out signal can be left undriven when the GPIOs are in the management enable state. This is a simple logic refactoring and does not change the logic function. The manual rewiring has been confirmed by LVS, but at least one GL simulation should be run to confirm that the logic function remains the same as before.
RTimothyEdwards
added
error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected the gpio_control_block so that the user_gpio_out signal
does not pass through an inverter, so that the input can remain
unconnected. Rewired the existing implementation to use an
alternative gate that has an inverting input so that the
user_gpio_out signal can be left undriven when the GPIOs are in
the management enable state. This is a simple logic refactoring
and does not change the logic function. The manual rewiring has
been confirmed by LVS, but at least one GL simulation should be
run to confirm that the logic function remains the same as before.