Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix submodule to point to main #287

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Fix submodule to point to main #287

merged 2 commits into from
Nov 23, 2023

Conversation

donn
Copy link
Member

@donn donn commented Nov 23, 2023

Forgot to do so for #276.

@donn donn requested a review from kareefardi November 23, 2023 14:48
@kareefardi
Copy link
Collaborator

kareefardi commented Nov 23, 2023 •
edited
Loading

Was it pointing to the branch or the PR ? There is no file diff.

@donn
Copy link
Member Author

donn commented Nov 23, 2023

@kareefardi It was pointing to the commit that only exists in the branch. After a squash and merge, it points to a new commit is in main.

@donn donn enabled auto-merge (squash) November 23, 2023 20:33
@donn donn merged commit f876189 into main Nov 23, 2023
79 checks passed
@donn donn deleted the fix_submodule branch December 11, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kareefardi kareefardi kareefardi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@donn @kareefardi