Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nix: add system as input argument #288

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Nix: add system as input argument #288

merged 1 commit into from
Nov 23, 2023

Conversation

7FM
Copy link
Contributor

@7FM 7FM commented Nov 23, 2023

  • Added a new argument to default.nix, system, as builtins.currentSystem is not available when using nix flakes (where in documentation it is described as "non-hermetic and impure": see https://nixos.wiki/wiki/Flakes). This change allows passing the system as argument and thus restores compatibility with nix flakes.

`builtins.currentSystem` is not available when using nix flakes.
This change allows passing the system as argument and thus restore compatibility with nix flakes.
Copy link
Member

@donn donn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@donn donn enabled auto-merge (squash) November 23, 2023 18:05
@donn donn merged commit 801d715 into efabless:main Nov 23, 2023
40 checks passed
@7FM 7FM deleted the patch-1 branch November 24, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants