Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Zero-Slack Paths Being Counted As Violations #556

Merged
merged 6 commits into from
Sep 23, 2024
Merged

Fix Zero-Slack Paths Being Counted As Violations #556

merged 6 commits into from
Sep 23, 2024

Conversation

kareefardi
Copy link
Collaborator

@kareefardi kareefardi commented Sep 22, 2024 •
edited by donn
Loading

  • OpenROAD.STA*PnR:
    • Fixed a bug in STA metrics where paths with exactly zero slack are counted as violations

Testing

Depends on efabless/openlane2-step-unit-tests#37
Fixes #505

@kareefardi
don't count 0 slack as violation
05e4e6f 
Signed-off-by: Kareem Farid <kareefardi@users.noreply.github.com>
@openlane-bot
Copy link
Collaborator

openlane-bot commented Sep 22, 2024 •
edited
Loading

Failed to create report:

Metrics not found for commit: 92c2a552a846d4c340a8abc24d3d20732b3b6877.

donn
donn reviewed Sep 23, 2024
View reviewed changes
Changelog.md Outdated Show resolved Hide resolved
donn and others added 2 commits September 23, 2024 12:21
@donn
Update Changelog.md
b24badf
@kareefardi
add handler to assert zero violation count
c4174f1 
Signed-off-by: Kareem Farid <kareefardi@users.noreply.github.com>
@donn donn changed the title Fix #505 Fix Zero-Slack Paths Being Counted As Violations Sep 23, 2024
@donn donn self-requested a review September 23, 2024 11:03
@donn donn merged commit 92c2a55 into main Sep 23, 2024
4 of 5 checks passed
@donn donn deleted the fix-sta-zero-slack branch September 23, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donn donn donn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Time borrowing causes flow to fail
3 participants
@kareefardi @openlane-bot @donn