Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OpenROAD.WriteViews to allow "bloating" occupied layers in output LEF #557

Merged
merged 4 commits into from
Sep 26, 2024
Merged

Update OpenROAD.WriteViews to allow "bloating" occupied layers in output LEF #557

merged 4 commits into from
Sep 26, 2024

Conversation

kareefardi
Copy link
Collaborator

@kareefardi kareefardi commented Sep 22, 2024 •
edited
Loading

  • OpenROAD.WriteViews:
    • Add OPENROAD_LEF_BLOAT_OCCUPIED_LAYERS with a default value of true

Fixes #555

@kareefardi
add OPENROAD_LEF_BLOAT_OCCUPIED_LAYERS
b6c4254 
Signed-off-by: Kareem Farid <kareefardi@users.noreply.github.com>
@kareefardi kareefardi changed the base branch from main to dev September 22, 2024 16:23
@openlane-bot
Copy link
Collaborator

openlane-bot commented Sep 22, 2024 •
edited
Loading

Metric comparisons are in beta. Please report bugs under the issues tab.

To create this report yourself, grab the metrics artifact from the CI run, extract them, and invoke python3 -m openlane.common.metrics compare-remote current --branch dev --table-verbosity ALL --table-out ./tables_all.md.

  • No changes to critical metrics were detected in analyzed designs.

Full tables ► https://gist.github.com/openlane-bot/55d6aa718f7be738907aaae31eba5a33

@donn
Copy link
Member

donn commented Sep 22, 2024

Think default should be true. The non-bloat one is pretty useless according to sylvain

@kareefardi
set OPENROAD_LEF_BLOAT_OCCUPIED_LAYERS default value to True
12b8c52 
Signed-off-by: Kareem Farid <kareefardi@users.noreply.github.com>
@donn donn changed the title Fix #555 Update OpenROAD.WriteViews to allow "bloating" occupied layers in output LEF Sep 23, 2024
@kareefardi
add missing argument
86d3cb2 
Signed-off-by: Kareem Farid <kareefardi@users.noreply.github.com>
@donn donn self-requested a review September 26, 2024 09:56
donn
donn approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@donn donn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@donn donn merged commit 8302f73 into dev Sep 26, 2024
107 checks passed
@donn donn deleted the add-or-lef-write-option branch September 29, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donn donn donn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an OpenROAD.WriteAbstractLEF step
3 participants
@kareefardi @openlane-bot @donn