Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Minimum Deployment Target to iOS 14 (Dropping iOS 13 Support) #44

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

efremidze
Copy link
Owner

@efremidze efremidze commented Aug 13, 2024

Description

This Pull Request updates the minimum deployment target of the framework to iOS 14, thereby dropping support for iOS 13. The following changes have been implemented:

Impact

  • Developers integrating this framework will need to target iOS 14 or later in their applications.
  • For projects that still require support for iOS 9 through iOS 13, version 4.x.x of the framework remains available.

Summary by CodeRabbit

  • New Features

    • Updated support policy to drop iOS 13 support; now optimized for iOS 14 and above.
    • Expanded accessibility of the requestedValues property for greater flexibility in utilizing visual effects.
  • Bug Fixes

    • Simplified property accessors for colorTint, colorTintAlpha, and blurRadius, improving clarity and maintainability.
  • Documentation

    • Revised README.md to reflect updated supported iOS versions, consolidating requirements to only support iOS 14.0 and above.
  • Chores

    • Incremented version from 4.1.5 to 5.0.0 in the podspec file to indicate a major release.

Copy link

coderabbitai bot commented Aug 13, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The updates in this release of the VisualEffectView project reflect a significant shift in focus towards supporting newer iOS versions, specifically dropping support for iOS 13. Key changes include the removal of certain properties and availability annotations, streamlining the functionality of visual effects, and enhancing the clarity of code. Additionally, the version number has been updated to 5.0.0, aligning the project with contemporary development practices.

Changes

File Change Summary
CHANGELOG.md Added version 5.0.0 entry, noting the removal of iOS 13 support and advising users needing compatibility to use 4.x.x.
README.md Updated iOS requirements to iOS 14.0+ and removed Xcode requirement, indicating a focus on newer features and improvements.
Sources/UIViewEffectView+Helpers.swift Removed properties ios14_blurRadius and ios14_colorTint. Changed requestedValues from private to public for broader accessibility.
Sources/VisualEffectView+SwiftUI.swift Removed availability annotations for VisualEffect and related components, broadening their compatibility.
Sources/VisualEffectView.swift Refactored accessors for colorTint, colorTintAlpha, and blurRadius to remove iOS version checks, simplifying the logic.
VisualEffectView.podspec Updated version from 4.1.5 to 5.0.0 and raised iOS deployment target from 9.0 to 14.0.
VisualEffectView.xcodeproj/project.pbxproj Renamed Swift files for clarity: VisualEffectView_SwiftUI.swift to VisualEffectView+SwiftUI.swift and UIViewEffectView_iOS14.swift to UIViewEffectView+Helpers.swift.

Possibly related issues

  • Update the library #43: The update directly addresses concerns about clarity and management in the library's implementation for iOS 14, which are highlighted in the issue.

Poem

🐇 In the meadow where colors blend,
The VisualEffect dances, a joyful trend.
With iOS 14, it leaps with delight,
No more shadows of old, just pure light.
A sprinkle of code, a hop and a cheer,
For clearer paths, the rabbit draws near! 🌈✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@efremidze efremidze mentioned this pull request Aug 13, 2024
@efremidze efremidze merged commit 0bf63a6 into master Aug 13, 2024
2 checks passed
@efremidze efremidze deleted the 5.0.0 branch August 13, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant