Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support remove unpartitioned same name cookie first #44

Merged
merged 4 commits into from
Dec 28, 2023

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Dec 27, 2023

No description provided.

Copy link

codecov bot commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7e01eba) 100.00% compared to head (068f7d8) 100.00%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #44   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          218       234   +16     
  Branches        57        61    +4     
=========================================
+ Hits           218       234   +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

test/lib/cookies.test.js Outdated Show resolved Hide resolved
Copy link

@killagu killagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DorothyGuan
Copy link

index.d.ts的removeUnpartitioned定义没加

@DorothyGuan
Copy link

DorothyGuan commented Dec 28, 2023

overwrite属性对removeUnpartitioned也有影响

@fengmk2
Copy link
Member Author

fengmk2 commented Dec 28, 2023

overwrite属性对removeUnpartitioned也有影响

已修复

@fengmk2 fengmk2 merged commit b81f041 into master Dec 28, 2023
11 checks passed
@fengmk2 fengmk2 deleted the support-remove-unpartitioned-cookie branch December 28, 2023 08:16
fengmk2 pushed a commit that referenced this pull request Dec 28, 2023
[skip ci]

## [2.8.2](v2.8.1...v2.8.2) (2023-12-28)

### Bug Fixes

* support remove unpartitioned same name cookie first ([#44](#44)) ([b81f041](b81f041))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants