feat: run a scheduler only once at startup #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #33 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 9 9
Lines 167 167
=====================================
Hits 167 167
Continue to review full report at Codecov.
|
|
@atian25 Why "continuous-integration/appveyor/branch" always not passed, something wrong? |
atian25
reviewed
Nov 16, 2017
lib/timer.js
Outdated
| @@ -19,8 +19,8 @@ class Timer { | |||
| */ | |||
| handler(key, schedule, listener) { | |||
| const { interval, cron, cronOptions, immediate } = schedule; | |||
| if (!interval && !cron) { | |||
| throw new Error('[egg-schedule] schedule.interval or schedule.cron must be present'); | |||
| if (!interval && !cron && !immediate) { | |||
There was a problem hiding this comment.
I had another idea, we should change this check to assert.
assert(interval || cron || immediate, '[egg-schedule] schedule.interval or schedule.cron or schedule.immediate must be present')
maybe it's permission problem, forgot it. |
|
3.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpasses