Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get adjusted memo #80

Merged
merged 1 commit into from
Jun 19, 2019
Merged

Get adjusted memo #80

merged 1 commit into from
Jun 19, 2019

Conversation

501st-alpha1
Copy link
Contributor

@501st-alpha1 501st-alpha1 commented Jun 18, 2019 •
edited
Loading

This fixes #71. If NAME is blank and MEMO is not, then run payee-matching from #62 on MEMO instead of NAME. (If NAME isn't blank, then MEMO may be a useful value.)

@501st-alpha1
Adjust memo instead if there is no payee
425f139 
If there is both a payee and a memo, then leave alone, because there
is a chance both are useful.

Fixes egh#71
@501st-alpha1
Copy link
Contributor Author

I had another commit here, but it broke the tests, and was orthogonal to this change anyway, so I removed it.

@egh egh self-assigned this Jun 19, 2019
@egh
Copy link
Owner

egh commented Jun 19, 2019

Looks good. Thank you!

@egh egh merged commit 188e898 into egh:master Jun 19, 2019
@501st-alpha1 501st-alpha1 deleted the get-adjusted-memo branch June 19, 2019 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@egh egh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

QFX (~= OFX) files with no NAME/payee field
2 participants
@501st-alpha1 @egh