Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inject option function support #199

Closed
wants to merge 2 commits into from
Closed

Conversation

shirotech
Copy link
Contributor

This gives user full control over how the styles are injected. @egoist can you please take a look, would be awesome if this can be merged. Thanks.

@shirotech
Copy link
Contributor Author

Not sure why circleci can't install node-sass for some reason, tests run fine on my machine.

@cdashrowe
Copy link

cdashrowe commented Oct 3, 2019

Not sure why circleci can't install node-sass for some reason, tests run fine on my machine.

Seems to be an issue with the updated version of node circleci is using, having the same issue on my PR.

@codecov
Copy link

codecov bot commented Oct 19, 2019

Codecov Report

Merging #199 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #199      +/-   ##
=========================================
+ Coverage   92.72%   92.8%   +0.07%     
=========================================
  Files           8       8              
  Lines         275     278       +3     
  Branches       99     101       +2     
=========================================
+ Hits          255     258       +3     
  Misses         20      20
Impacted Files Coverage Δ
src/postcss-loader.js 93.54% <100%> (+0.14%) ⬆️
src/index.js 96.34% <100%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e63c9ae...80a27ca. Read the comment docs.

@shirotech
Copy link
Contributor Author

@cdashrowe I've changed node to use lts instead of latest which should be more stable and seems to have fixed the issue.

Would be good if anyone has merging rights to look at this. Many thanks.

README.md Show resolved Hide resolved
@himself65
Copy link
Collaborator

landed at 545dc80 and b364cbe

@himself65 himself65 closed this Mar 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants