Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: run experimentalDts only once #1236

Merged
merged 1 commit into from
Oct 26, 2024
Merged

fix: run experimentalDts only once #1236

merged 1 commit into from
Oct 26, 2024

Conversation

aryaemami59
Copy link
Contributor

This PR:

  • Removes duplicate function call of experimentalDtsTask which resulted in experimentalDts running twice.

@codesandbox CodeSandbox
Copy link

codesandbox bot commented Oct 18, 2024

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

@vercel Vercel
Copy link

vercel bot commented Oct 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tsup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2024 3:15am

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Oct 18, 2024 •
edited
Loading

Open in Stackblitz

pnpm add https://pkg.pr.new/egoist/tsup@1236

commit: 7a2d5ce

ocavue
ocavue approved these changes Oct 26, 2024
View reviewed changes
Copy link
Collaborator

@ocavue ocavue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aryaemami59!

@ocavue ocavue merged commit fddd451 into egoist:main Oct 26, 2024
12 checks passed
@aryaemami59 aryaemami59 deleted the run-experimentalDts-once branch October 26, 2024 04:52
@renovate renovate bot mentioned this pull request Nov 1, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocavue ocavue ocavue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aryaemami59 @ocavue