Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle exception occurred when the element doesn't exist #28

Merged
merged 1 commit into from
Jun 24, 2019

Conversation

chatoo2412
Copy link
Contributor

execute function is throttled and the element can be removed between event and execution.

@cb109
Copy link

cb109 commented Jun 24, 2019

@egoist Could you please merge this fix in and release a new version? The element is easily removed e.g. in cypress tests where navigation is performed very quickly, which for me often results in errors like

Uncaught TypeError: Cannot read property 'getBoundingClientRect' of undefined

Update: I have just confirmed the fix in this PR solves my issue

@egoist egoist merged commit cedf6cd into egoist:master Jun 24, 2019
@egoist
Copy link
Owner

egoist commented Jun 24, 2019

🎉 This PR is included in version 0.2.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@cb109
Copy link

cb109 commented Jun 25, 2019

Thanks 🤗 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants