Backlight reverts to full brightness

[kittenarmy]

v0.20.1

Steps to reproduce:
Set BLMax to 5 (BLMin stay set 0), press M to confirm - backlight reverts to full brightness until press exit.
Press M and backlight is full brightness again.

Also triggered by:
Press M to open menu, scroll with up/down to BackLt - backlight reverts to full brightness until press exit.

[JuantAldea]

Brightness is set to FULL when traversing backlight menu options. I think it actually goes back to MAX after any two keypresses, at least that's one of the cases.

[egzumer]

This is inherited from 1o11 and I kept it. The idea is I guess to allow bringing back the backligth settings in a dark when it was set to off.

[JuantAldea]

I have proposed solution of the "side effects" of this, although it is really cosmetic and it increases the binary size so I have mixed feelings about it.

[gartnl]

I actually like the backlight at FULL when entering or traversing the menu, it's kind of a failsafe. Just imagine you are by accident setting MAX to 1 ( might happen if you think you are setting MIN ). Press exit twice or simply wait for the timeout of the backlight.
Setting it to MAX when leaving the menu is fine, but keep it on FULL as long as you are in MENU.

[JuantAldea]

Yes, the failsafe is out of discussion. But it is also true that it is not returned to the configured max BL exactly when it should.

If you go above the Blit options, you will see that the BLit does not return to the configured until you are "two options away" from them or, actually, two key-presses away.

[egzumer]

The button pressing functions are a mess, I know it is not perfect. I didn't want to spend more time fighting that, this was the best I could get it to be then.
I'll take a look at the solution later.

[egzumer]

It is cosmetic and takes some memory space, but the operation is nicer, I like it. I tried to make it work like that before.

[kittenarmy]

I actually like the backlight at FULL when entering or traversing the menu, it's kind of a failsafe. Just imagine you are by accident setting MAX to 1 ( might happen if you think you are setting MIN ). Press exit twice or simply wait for the timeout of the backlight. Setting it to MAX when leaving the menu is fine, but keep it on FULL as long as you are in MENU.

If you have dark adapted eyes, using the radio with this behaviour is actually painful and not at all intuitive. It somewhat defeats the point of having option to lower the brightness. I prefer set and forget and expect the same. I suggest it be a build option like the guarding of TX on all frequencies.

[kittenarmy]

This is inherited from 1o11 and I kept it. The idea is I guess to allow bringing back the backligth settings in a dark when it was set to off.

Do you know where in the repo it is reverting? I tried searching for BACKLIGHT_SetBrightness but cannot find where it is. Did it get refactored yet? I'd create a pull to add some flag to makefile and read in menu e.g. #ifdef ENABLE_MENU_MAX_BACKLIGHT = 0 .

[egzumer]

I'm raising the stakes: 1151cf8

Interestingly, there is more code but it takes 52B less space :)

[kittenarmy]

I'm raising the stakes: 1151cf8

Interestingly, there is more code but it takes 52B less space :)

This is great. Thank you!