New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Crash caused by wavelength controls #118

Merged

ehb54 merged 2 commits into ehb54:master from doluk:us_edit_issue306

Jun 20, 2024

Collaborator

doluk commented Jun 19, 2024

https://github.com/ehb54/ultrascan-tickets/issues/306


          Fix: Crash caused by wavelength controls

ce7b2ce

doluk requested a review from ehb54

June 19, 2024 19:08

Owner

ehb54 commented Jun 19, 2024

Minor comment note https://github.com/ehb54/ultrascan3/pull/118/files#diff-bc9b51794d4e844de36b755763d8754ea2c4adaea4eb72b30df1625f44ac25c8R10569
The comment doesn't really match the logic. The check is if the new start is greater than the end.


          fix: comment doesn't align with code

96620af

ehb54 approved these changes

View reviewed changes

ehb54 merged commit 7b2d4c4 into ehb54:master

4 checks passed

doluk deleted the us_edit_issue306 branch

July 11, 2024 07:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet