Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for cosedimenting components #27

Closed
wants to merge 209 commits into from
Closed

Conversation

doluk
Copy link
Collaborator

@doluk doluk commented Mar 30, 2022

No description provided.

@ehb54
Copy link
Owner

ehb54 commented Mar 30, 2022

@doluk
This seems ok to merge, waiting for an update on the us3_sql pull request.

Note - updating any system with database changes generally requires careful handling (either upgrading the db with a standard procedure or manually inserting the new tables and stored procedures)

@doluk
Copy link
Collaborator Author

doluk commented Mar 30, 2022

Should I write an update procedure for this too? Where should I put it if so? @ehb54

@ehb54
Copy link
Owner

ehb54 commented Mar 30, 2022

Should I write an update procedure for this too? Where should I put it if so? @ehb54

@doluk
Specific databases can be in various states (generally sync'd with a specific us3_sql git commit - occasionally with some hand patches - particularly on dev servers). Perhaps a subtree under us3_sql/patches/something-descriptive
with a README.md describing the usage & applicability.

Note this is not a requirement, we have established procedures for the general case. However, for testing, this will save us time (established procedures require exporting, dropping, recreating & reimporting for each database. automated, but time consuming and requires idle users and jobs)

@doluk
Copy link
Collaborator Author

doluk commented Mar 30, 2022

In this case the update only consists in adding new tables and procedures. I don't know if the time is worth it this time. If you want one, I can do it (after I figured out what the good practice for such things is xD)

@doluk
Copy link
Collaborator Author

doluk commented Mar 30, 2022

@ehb54
I added in the pull request an sql file containing all stuff I changed so it is just executing this file. Let me know if you want something changed (or change it yourself, if you want)

Signed-off-by: doluk <69309597+doluk@users.noreply.github.com>
Signed-off-by: doluk <69309597+doluk@users.noreply.github.com>
Signed-off-by: doluk <69309597+doluk@users.noreply.github.com>
Signed-off-by: doluk <69309597+doluk@users.noreply.github.com>
@doluk doluk marked this pull request as draft June 11, 2024 11:00
doluk added 24 commits June 14, 2024 05:53
Signed-off-by: doluk <69309597+doluk@users.noreply.github.com>
Signed-off-by: doluk <69309597+doluk@users.noreply.github.com>
# Conflicts:
#	gui/us_mwl_data.cpp
#	gui/us_plot3d.cpp
#	gui/us_plot3d.h
#	gui/us_plot3d_xyz.cpp
#	programs/us_fematch/us_advanced_fem.cpp
Signed-off-by: doluk <69309597+doluk@users.noreply.github.com>
Signed-off-by: doluk <69309597+doluk@users.noreply.github.com>
Signed-off-by: doluk <69309597+doluk@users.noreply.github.com>
@doluk doluk closed this Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants