Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/594 error constraint template #262

Merged
merged 4 commits into from
Oct 11, 2021
Merged

Bugfix/594 error constraint template #262

merged 4 commits into from
Oct 11, 2021

Conversation

subigre
Copy link

@subigre subigre commented Oct 6, 2021

Resolves ehrbase/ehrbase#594

  • Fixes java.lang.NullPointerException when protocol.items is null or [].
  • Fixes several code analysis issues.

stefanspiska
stefanspiska requested changes Oct 7, 2021
View reviewed changes
Copy link
Contributor

@stefanspiska stefanspiska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some stuff

But I think that @chevalleyc should also take a look.

serialisation/src/main/java/org/ehrbase/serialisation/dbencoding/CompositionSerializer.java Outdated Show resolved Hide resolved
serialisation/src/main/java/org/ehrbase/serialisation/dbencoding/CompositionSerializer.java Outdated Show resolved Hide resolved
serialisation/src/main/java/org/ehrbase/serialisation/dbencoding/CompositionSerializer.java Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Oct 7, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

68.6% 68.6% Coverage
0.0% 0.0% Duplication

@stefanspiska stefanspiska merged commit d1d05a9 into develop Oct 11, 2021
@stefanspiska stefanspiska deleted the bugfix/594_error_constraint_template branch October 11, 2021 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanspiska stefanspiska stefanspiska approved these changes

@chevalleyc chevalleyc chevalleyc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when constraint in template is not binded
3 participants
@subigre @chevalleyc @stefanspiska