Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CDR-1512] Fix flat parsing of ObjectVersionId #622

Merged
merged 2 commits into from
Jul 22, 2024
Merged

[CDR-1512] Fix flat parsing of ObjectVersionId #622

merged 2 commits into from
Jul 22, 2024

Conversation

alexlehn
Copy link
Contributor

Changes

Fix for: ehrbase/ehrbase#1368

  • Fix flat format parsing of ObjectVersionId
  • Add tests to ensure ObjectVersionId are parsed correctly
  • Tweaked setup of Flat de-/-Serialization

Pre-Merge checklist

  • New code is tested
  • Present and new tests pass
  • Documentation is updated
  • The build is working without errors
  • No new Sonar issues introduced
  • Changelog is updated
  • Code has been reviewed

@alexlehn alexlehn force-pushed the feature/CDR-1512-composition-FLAT-and-STRUCTURED-invalid-object-version-id branch from 5669ec0 to d8f1e02 Compare July 19, 2024 13:22
@alexlehn alexlehn force-pushed the feature/CDR-1512-composition-FLAT-and-STRUCTURED-invalid-object-version-id branch from d8f1e02 to a834050 Compare July 19, 2024 13:41
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@alexlehn alexlehn requested a review from micha1970 July 19, 2024 14:33
@alexlehn alexlehn merged commit 83e6b5f into develop Jul 22, 2024
6 checks passed
@alexlehn alexlehn deleted the feature/CDR-1512-composition-FLAT-and-STRUCTURED-invalid-object-version-id branch July 22, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micha1970 micha1970 micha1970 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexlehn @micha1970