fix: update regex for detect merge commits after dropping bors #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've run it locally. With this patch |
weihanglo
added a commit
to weihanglo/triagebot
that referenced
this pull request
Nov 28, 2024
Cargo has migrated to GitHub merge queue: rust-lang/cargo#14718 The regex doesn't work for merge commit made by GitHub merge queue. This PR adds extra regex pattern to capture that. This regex has been proved working locally. See <ehuss/cargo-new-release#2>
weihanglo
force-pushed
the
user-token
branch
from
c8f2869 to
c1807fd
Compare
weihanglo
added a commit
to weihanglo/triagebot
that referenced
this pull request
Nov 28, 2024
Cargo has migrated to GitHub merge queue: rust-lang/cargo#14718 The regex doesn't work for merge commit made by GitHub merge queue. This PR adds extra regex pattern to capture that. This regex has been proved working locally. See <ehuss/cargo-new-release#2>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c8f2869 is probably more important. It updates how we detect merge PRs for updating Cargo milestone after migrating away from bors. The regex is a bit brittle, though I expect it should be fine for short term.