Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deposit Token with allowance check #11

Closed
ceres3idoo opened this issue Feb 15, 2019 · 0 comments
Closed

Deposit Token with allowance check #11

ceres3idoo opened this issue Feb 15, 2019 · 0 comments
Assignees
@andreafspeziale @ceres3idoo
Labels
enhancement New feature or request
Milestone
SDK v1.2.0

Comments

@ceres3idoo
Copy link
Contributor

📝 Issue

As a user I want to deposit token without allowance check and manual approve operation.

📖 Details

If you are going to deposit token , you need actually to run the following operations:

  • Approve token transafer ( using Erc20TokenService)
  • Check the allowance calling Erc20 smart contract (using Erc20TokenService)
  • Deposit token (using TradingWalletService)

For this it will be implemented a function which manages the flow described above.
@ceres3idoo ceres3idoo added the enhancement New feature or request label Feb 15, 2019
@ceres3idoo ceres3idoo self-assigned this Feb 15, 2019
ceres3idoo added a commit that referenced this issue Feb 18, 2019
@ceres3idoo
#11 add nowait rule in eslint
364b06b
ceres3idoo added a commit that referenced this issue Feb 18, 2019
@ceres3idoo
#11 Add tests for DepositAsync
e3680a9
ceres3idoo added a commit that referenced this issue Feb 18, 2019
@ceres3idoo
#11 Add isTransactionMined in TransactionLib
24d0eb0
ceres3idoo added a commit that referenced this issue Feb 18, 2019
@ceres3idoo
#11 Add TradingWalletFacade
0612ec5
ceres3idoo added a commit that referenced this issue Feb 18, 2019
@ceres3idoo
#11 Add TradingWalletFacedBuilder
5fab4fa
ceres3idoo added a commit that referenced this issue Feb 18, 2019
@ceres3idoo
#11 Adjust import for facade
1f1a916
ceres3idoo added a commit that referenced this issue Feb 18, 2019
@ceres3idoo
#11 Add Example
a67d009
@ceres3idoo ceres3idoo mentioned this issue Feb 18, 2019
Merged
ceres3idoo added a commit that referenced this issue Feb 18, 2019
@ceres3idoo
#11 add nowait rule in eslint
13f1ab2
ceres3idoo added a commit that referenced this issue Feb 18, 2019
@ceres3idoo
#11 Add tests for DepositAsync
4a63984
ceres3idoo added a commit that referenced this issue Feb 18, 2019
@ceres3idoo
#11 Add isTransactionMined in TransactionLib
1f740ce
ceres3idoo added a commit that referenced this issue Feb 18, 2019
@ceres3idoo
#11 Add TradingWalletFacade
ceb18ad
ceres3idoo added a commit that referenced this issue Feb 18, 2019
@ceres3idoo
#11 Add TradingWalletFacedBuilder
0217737
ceres3idoo added a commit that referenced this issue Feb 18, 2019
@ceres3idoo
#11 Adjust import for facade
5538706
ceres3idoo added a commit that referenced this issue Feb 18, 2019
@ceres3idoo
#11 Add Example
f48a407
ceres3idoo added a commit that referenced this issue Feb 19, 2019
@ceres3idoo
#11 Add getBalanceAsync in Erc20TokenService
e3854da
ceres3idoo added a commit that referenced this issue Feb 19, 2019
@ceres3idoo
#11 Adjust getBalanceOfAsync
48e2acc
ceres3idoo added a commit that referenced this issue Feb 19, 2019
@ceres3idoo
#11 Adjust getBalanceOf example
1140cea
ceres3idoo added a commit that referenced this issue Feb 19, 2019
@ceres3idoo
#11 Refactor TradingWalletFacade
62ae3a2
ceres3idoo added a commit that referenced this issue Feb 19, 2019
@ceres3idoo
#11 remove unused curtom error
023cae7
ceres3idoo added a commit that referenced this issue Feb 19, 2019
@ceres3idoo
#11 Update readme and changelog
185af4f
ceres3idoo added a commit that referenced this issue Feb 19, 2019
@ceres3idoo
#11 Adjust log level in TransactionLib
0e8c9f2
ceres3idoo added a commit that referenced this issue Feb 19, 2019
@ceres3idoo
#11 Adjust import in depositToken examples
a539e06
@andreafspeziale andreafspeziale self-assigned this Feb 19, 2019
andreafspeziale pushed a commit that referenced this issue Feb 20, 2019
#11 Improve README quick start
c52be73
ceres3idoo added a commit that referenced this issue Feb 22, 2019
@ceres3idoo
#11 Set nonce manually in TradingWalletFacade
d235137
ceres3idoo added a commit that referenced this issue Feb 22, 2019
@ceres3idoo
#11 Adjust deposit with approve example
a449b4e
ceres3idoo added a commit that referenced this issue Feb 22, 2019
@ceres3idoo
#11 Adjust typo from approveTrasferAsync to approveTransferAsync
4c7a7a8
ceres3idoo added a commit that referenced this issue Feb 22, 2019
@ceres3idoo
#11 add nowait rule in eslint
8391bed
ceres3idoo added a commit that referenced this issue Feb 22, 2019
@ceres3idoo
#11 Add tests for DepositAsync
5fbd82e
ceres3idoo added a commit that referenced this issue Feb 22, 2019
@ceres3idoo
#11 Add isTransactionMined in TransactionLib
c355a1e
ceres3idoo added a commit that referenced this issue Feb 22, 2019
@ceres3idoo
#11 Add TradingWalletFacade
5ad8a7c
ceres3idoo added a commit that referenced this issue Feb 22, 2019
@ceres3idoo
#11 Add TradingWalletFacedBuilder
e83268a
ceres3idoo added a commit that referenced this issue Feb 22, 2019
@ceres3idoo
#11 Adjust import for facade
26ac0bd
ceres3idoo added a commit that referenced this issue Feb 22, 2019
@ceres3idoo
#11 Add Example
6a5ab25
ceres3idoo added a commit that referenced this issue Feb 22, 2019
@ceres3idoo
#11 Add getBalanceAsync in Erc20TokenService
a27c999
ceres3idoo added a commit that referenced this issue Feb 22, 2019
@ceres3idoo
#11 Adjust getBalanceOfAsync
2d672a2
ceres3idoo added a commit that referenced this issue Feb 22, 2019
@ceres3idoo
#11 Adjust getBalanceOf example
b4ce6ce
ceres3idoo added a commit that referenced this issue Feb 22, 2019
@ceres3idoo
#11 Refactor TradingWalletFacade
4c54c39
ceres3idoo added a commit that referenced this issue Feb 22, 2019
@ceres3idoo
#11 remove unused curtom error
7bd790d
ceres3idoo added a commit that referenced this issue Feb 22, 2019
@ceres3idoo
#11 Update readme and changelog
4b582b4
ceres3idoo added a commit that referenced this issue Feb 22, 2019
@ceres3idoo
#11 Adjust log level in TransactionLib
e28f04b
ceres3idoo added a commit that referenced this issue Feb 22, 2019
@ceres3idoo
#11 Adjust import in depositToken examples
dc29e48
ceres3idoo added a commit that referenced this issue Feb 22, 2019
@ceres3idoo
#11 Remove isTransactionMined and transfrom getEstimationGas from pri…
d5d6dcd 
…vate to public
ceres3idoo added a commit that referenced this issue Feb 22, 2019
@ceres3idoo
#11 Adjust tests
1804bc6
ceres3idoo added a commit that referenced this issue Feb 22, 2019
@ceres3idoo
#11 Get gas estimation to set gas in deposit token transaction
8f48340
ceres3idoo added a commit that referenced this issue Feb 22, 2019
@ceres3idoo
#11 Get nonce is public now in TransactionLiv
04038ce
ceres3idoo added a commit that referenced this issue Feb 22, 2019
@ceres3idoo
#11 Set nonce manually in TradingWalletFacade
bd308f6
ceres3idoo added a commit that referenced this issue Feb 22, 2019
@ceres3idoo
#11 Adjust deposit with approve example
85ba160
ceres3idoo added a commit that referenced this issue Feb 22, 2019
@ceres3idoo
#11 Adjust typo from approveTrasferAsync to approveTransferAsync
914fa0a
andreafspeziale added a commit that referenced this issue Feb 22, 2019
@andreafspeziale
#11 Add new transaction lib public functions to its interface and int…
275c7ed 
…erface tests
andreafspeziale added a commit that referenced this issue Feb 22, 2019
@andreafspeziale
#11 Add log to deposit with approve example
6826a92
andreafspeziale pushed a commit that referenced this issue Feb 22, 2019
@ceres3idoo @andreafspeziale
#11 Add deposit token with approve
4a73815
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreafspeziale andreafspeziale

@ceres3idoo ceres3idoo

Labels
enhancement New feature or request
Projects
None yet
Milestone
SDK v1.2.0
Development

No branches or pull requests
2 participants
@andreafspeziale @ceres3idoo