Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should multiple FLOW_CONTEXT links be allowed? #170

Closed
d-stahl-ericsson opened this issue Feb 7, 2018 · 3 comments
Closed

Should multiple FLOW_CONTEXT links be allowed? #170

d-stahl-ericsson opened this issue Feb 7, 2018 · 3 comments
Assignees
@d-stahl-ericsson
Labels
protocol All protocol changes

Comments

@d-stahl-ericsson
Copy link
Contributor

The documentation currently says multiple FLOW_CONTEXT links aren't allowed. It appears reasonable that multiple overlapping contexts should be allowed. Any downsides to that?

Discuss!
@erobged
Copy link

erobged commented Feb 14, 2018

We have disucssed this and it is agreed that multiple FLOW_CONTEXT should be allowed.
@l-ohlen-ericsson will make updates and pull request.

@l-ohlen-ericsson l-ohlen-ericsson mentioned this issue Feb 14, 2018
Closed
@d-stahl-ericsson d-stahl-ericsson mentioned this issue Feb 15, 2018
Closed
@d-stahl-ericsson
Copy link
Contributor Author

Right, so let's make a PR. But #136 is a prerequisite.

@d-stahl-ericsson d-stahl-ericsson self-assigned this Feb 15, 2018
@d-stahl-ericsson d-stahl-ericsson mentioned this issue Feb 15, 2018
Merged
l-ohlen-ericsson added a commit to l-ohlen-ericsson/eiffel that referenced this issue Feb 19, 2018
@l-ohlen-ericsson
Change to allow multiple FLOW_CONTEXT (eiffel-community#170)
608ffab
l-ohlen-ericsson added a commit to l-ohlen-ericsson/eiffel that referenced this issue Feb 19, 2018
@l-ohlen-ericsson
Change to allow multiple FLOW_CONTEXT (eiffel-community#170)
9c9928a
l-ohlen-ericsson added a commit to l-ohlen-ericsson/eiffel that referenced this issue Feb 19, 2018
@l-ohlen-ericsson
Change to allow multiple FLOW_CONTEXT (eiffel-community#170)
6be8f0c
l-ohlen-ericsson added a commit to l-ohlen-ericsson/eiffel that referenced this issue Feb 19, 2018
@l-ohlen-ericsson
Change to allow multiple FLOW_CONTEXT (eiffel-community#170)
ee1599b
l-ohlen-ericsson added a commit to l-ohlen-ericsson/eiffel that referenced this issue Feb 19, 2018
@l-ohlen-ericsson
Change to allow multiple FLOW_CONTEXT (eiffel-community#170)
17ff051
l-ohlen-ericsson added a commit to l-ohlen-ericsson/eiffel that referenced this issue Feb 19, 2018
@l-ohlen-ericsson
Change to allow multiple FLOW_CONTEXT (eiffel-community#170)
cae83fd
l-ohlen-ericsson added a commit to l-ohlen-ericsson/eiffel that referenced this issue Feb 19, 2018
@l-ohlen-ericsson
Change to allow multiple FLOW_CONTEXT (eiffel-community#170)
c986413
l-ohlen-ericsson added a commit to l-ohlen-ericsson/eiffel that referenced this issue Feb 19, 2018
@l-ohlen-ericsson
Change to allow multiple FLOW_CONTEXT (eiffel-community#170)
f2d85cc
l-ohlen-ericsson added a commit to l-ohlen-ericsson/eiffel that referenced this issue Feb 19, 2018
@l-ohlen-ericsson
Change to allow multiple FLOW_CONTEXT (eiffel-community#170)
5e89274
l-ohlen-ericsson added a commit to l-ohlen-ericsson/eiffel that referenced this issue Feb 19, 2018
@l-ohlen-ericsson
Change to allow multiple FLOW_CONTEXT (eiffel-community#170)
4650553
l-ohlen-ericsson added a commit to l-ohlen-ericsson/eiffel that referenced this issue Feb 19, 2018
@l-ohlen-ericsson
Change to allow multiple FLOW_CONTEXT (eiffel-community#170)
29aeb26
l-ohlen-ericsson added a commit to l-ohlen-ericsson/eiffel that referenced this issue Feb 19, 2018
@l-ohlen-ericsson
Change to allow multiple FLOW_CONTEXT (eiffel-community#170)
1341800
l-ohlen-ericsson added a commit to l-ohlen-ericsson/eiffel that referenced this issue Feb 19, 2018
@l-ohlen-ericsson
Change to allow multiple FLOW_CONTEXT (eiffel-community#170)
5ac90cc
l-ohlen-ericsson added a commit to l-ohlen-ericsson/eiffel that referenced this issue Feb 19, 2018
@l-ohlen-ericsson
Change to allow multiple FLOW_CONTEXT (eiffel-community#170)
e3233ee
l-ohlen-ericsson added a commit to l-ohlen-ericsson/eiffel that referenced this issue Feb 19, 2018
@l-ohlen-ericsson
Change to allow multiple FLOW_CONTEXT (eiffel-community#170)
6388562
l-ohlen-ericsson added a commit to l-ohlen-ericsson/eiffel that referenced this issue Feb 19, 2018
@l-ohlen-ericsson
Change to allow multiple FLOW_CONTEXT (eiffel-community#170)
f6efefa
l-ohlen-ericsson added a commit to l-ohlen-ericsson/eiffel that referenced this issue Feb 19, 2018
@l-ohlen-ericsson
Change to allow multiple FLOW_CONTEXT (eiffel-community#170)
1a15800
l-ohlen-ericsson added a commit to l-ohlen-ericsson/eiffel that referenced this issue Feb 19, 2018
@l-ohlen-ericsson
Change to allow multiple FLOW_CONTEXT (eiffel-community#170)
69e937c
l-ohlen-ericsson added a commit to l-ohlen-ericsson/eiffel that referenced this issue Feb 19, 2018
@l-ohlen-ericsson
Change to allow multiple FLOW_CONTEXT (eiffel-community#170)
ee5ff4d
l-ohlen-ericsson added a commit to l-ohlen-ericsson/eiffel that referenced this issue Feb 19, 2018
@l-ohlen-ericsson
Change to allow multiple FLOW_CONTEXT (eiffel-community#170)
22ba548
l-ohlen-ericsson added a commit to l-ohlen-ericsson/eiffel that referenced this issue Feb 19, 2018
@l-ohlen-ericsson
Change to allow multiple FLOW_CONTEXT (eiffel-community#170)
e76e00f
l-ohlen-ericsson added a commit to l-ohlen-ericsson/eiffel that referenced this issue Feb 19, 2018
@l-ohlen-ericsson
Change to allow multiple FLOW_CONTEXT (eiffel-community#170)
51afa4c
@l-ohlen-ericsson l-ohlen-ericsson mentioned this issue Feb 19, 2018
Closed
d-stahl-ericsson added a commit to d-stahl-ericsson/eiffel that referenced this issue Feb 19, 2018
@d-stahl-ericsson
Changed FLOW_CONTEXT link type to allow multiple links in same event
1d03119 
As per Issue eiffel-community#170, FLOW_CONTEXT has been changed in all events
to allow for multiple FLOW_CONTEXT links in the same event. This
is because situations where an entity may need to be associated
with multiple FlowContexts, e.g. a program and a track, are
common and there is no reason to restrict linkage to a single
FlowContext.

All events have been stepped one minor version. Schemas have
been supplied for the new versions. Note that the new schemas
are identical, however, as there is currently no validation
of links.

Where deemed appropriate, event examples have been stepped to
the new versions. One event example had two FLOW_CONTEXT links
added so that this new change is represented in at least one place.
@d-stahl-ericsson d-stahl-ericsson mentioned this issue Feb 19, 2018
Merged
d-stahl-ericsson added a commit that referenced this issue Feb 20, 2018
@d-stahl-ericsson
Changed FLOW_CONTEXT link type to allow multiple links in same event (#…
dd90ade 
…179)

As per Issue #170, FLOW_CONTEXT has been changed in all events
to allow for multiple FLOW_CONTEXT links in the same event. This
is because situations where an entity may need to be associated
with multiple FlowContexts, e.g. a program and a track, are
common and there is no reason to restrict linkage to a single
FlowContext.

All events have been stepped one minor version. Schemas have
been supplied for the new versions. Note that the new schemas
are identical, however, as there is currently no validation
of links.

Where deemed appropriate, event examples have been stepped to
the new versions. One event example had two FLOW_CONTEXT links
added so that this new change is represented in at least one place.

Added links to previous non-edition-tagged versions in event Version History
@l-ohlen-ericsson
Copy link
Contributor

Resolved

@magnusbaeck magnusbaeck added the protocol All protocol changes label Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@d-stahl-ericsson d-stahl-ericsson

Labels
protocol All protocol changes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@magnusbaeck @d-stahl-ericsson @l-ohlen-ericsson @erobged