Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Description of meta.time format should be distinct and clear #177

Closed
l-ohlen-ericsson opened this issue Feb 19, 2018 · 1 comment
Closed

Description of meta.time format should be distinct and clear #177

l-ohlen-ericsson opened this issue Feb 19, 2018 · 1 comment
Milestone
Edition Agen

Comments

@l-ohlen-ericsson
Copy link
Contributor

l-ohlen-ericsson commented Feb 19, 2018 •
edited
Loading

Description

The meta.time format should be described more distinct and clear, since the current description could be miss interpreted.

File the-meta-object.md

Motivation

Currently the meta.time field is described as Milliseconds since epoch.
Since the Eiffel events can be generated in many different time zones, the epoch in this context is probably referring to epoch as being UNIX Epoch time (or Unix time / POSIX time) where the time zone is then UTC.

So the epoch description should either be changed to UNIX Epoch time, or to explicit have UTC time zone set.

Exemplification

epoch could been interpreted as epoch in current time zone with the current description, that will lead to that events will have unaligned times.

Benefits

Clear and distinct definition of epoch will ensure that event times are correctly set regardless in which time zone they are created

Possible Drawbacks

None
@d-stahl-ericsson
Copy link
Contributor

Sure, let's just call it UNIX Epoch time.

@d-stahl-ericsson d-stahl-ericsson modified the milestones: Drop 4, Edition Agen Jun 27, 2018
d-stahl-ericsson added a commit to d-stahl-ericsson/eiffel that referenced this issue Aug 7, 2018
@d-stahl-ericsson
Rephrased meta.time format in all event types.
f6eeb03 
As per issue eiffel-community#177, clarified the description of meta.time
format for all event types. No stepping of event versions
required as the actual event syntax is unaffected by this change.
@d-stahl-ericsson d-stahl-ericsson mentioned this issue Aug 7, 2018
Merged
d-stahl-ericsson added a commit that referenced this issue Aug 17, 2018
@d-stahl-ericsson
Rephrased meta.time format in all event types. (#194)
4231eba 
As per issue #177, clarified the description of meta.time format for all event types. No stepping of event versions required as the actual event syntax is unaffected by this change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Edition Agen
Development

No branches or pull requests
2 participants
@d-stahl-ericsson @l-ohlen-ericsson