Prepare for release of Lyon #277

magnusbaeck · 2021-09-28T15:20:30Z

Applicable Issues

Fixes #272

Description of the Change

Like what was done for the release of the Paris edition (commit d8fd110) we do two things in preparation of the release of the Lyon edition:

Replace all "Current version" references in the Version History tables in the eiffel-vocabulary files with a reference to the (not yet existing) edition-lyon tag.
Claim the Lyon edition in the table in versioning.md.

Alternate Designs

None.

Benefits

Makes new protocol versions widely available.

Possible Drawbacks

None.

Sign-off

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.

Signed-off-by: Magnus Bäck <magnus.back@axis.com>

e-backmark-ericsson · 2021-09-30T08:21:05Z

Should we set the milestone "Edition Lyon" on this PR as well? I'm not familiar with how milestones work in GitHub.

magnusbaeck · 2021-09-30T08:25:21Z

Milestones are just containers of issues and PRs so it depends on how we want to use the milestones. So far the Lyon milestone has only contained issues and no PRs so to stick with that ad hoc convention we should leave this PR out (but add the #272 issue).

e-backmark-ericsson · 2021-09-30T08:27:12Z

eiffel-vocabulary/EiffelActivityFinishedEvent.md

-| 3.2.0     | Current version                                        | Add links.domainId member (see [Issue 233](https://github.com/eiffel-community/eiffel/issues/233)). |
-| 3.1.0     | Current version                                        | Add `data.persistentLogs.{mediaType,tags}`.   |
+| 3.2.0     | [edition-lyon](../../../tree/edition-lyon)             | Add links.domainId member (see [Issue 233](https://github.com/eiffel-community/eiffel/issues/233)). |
+| 3.1.0     | [edition-lyon](../../../tree/edition-lyon)             | Add `data.persistentLogs.{mediaType,tags}`.   |


Should we really say that 3.1.0 was introduced in edition-lyon? Or should we instead just have a commit id here as it is done for 2.0.0? As edition Lyon contains 3.2.0.

Suggested change

| 3.1.0 | [edition-lyon](../../../tree/edition-lyon) | Add `data.persistentLogs.{mediaType,tags}`. |

| 3.1.0 | No edition set | Add `data.persistentLogs.{mediaType,tags}`. |

Emil and I talked about this and it's not clear what the Version history table is supposed to convey. Listing both 3.1.0 and 3.2.0 (as in this example) as introduced in Lyon is reasonable in the sense that the changes in both versions were first introduced in the Lyon edition, but if we interpret the table as something that focuses on the event versions it's only 3.2.0 that was introduced in Lyon. 3.1.0 is an "orphan" version that nobody is expected to be using (although it's technically fine to use it).

I'm fine with just about anything right now but I'd like us to figure out something that makes sense and (post-Lyon) align all the Version history tables accordingly.

e-backmark-ericsson · 2021-09-30T08:27:51Z

eiffel-vocabulary/EiffelActivityStartedEvent.md

-| 4.2.0     | Current version                                        | Add links.domainId member (see [Issue 233](https://github.com/eiffel-community/eiffel/issues/233)). |
-| 4.1.0     | Current version                                        | Add `data.liveLogs.{mediaType,tags}`.   |
+| 4.2.0     | [edition-lyon](../../../tree/edition-lyon)             | Add links.domainId member (see [Issue 233](https://github.com/eiffel-community/eiffel/issues/233)). |
+| 4.1.0     | [edition-lyon](../../../tree/edition-lyon)             | Add `data.liveLogs.{mediaType,tags}`.   |


Same comment as for ActF

e-backmark-ericsson · 2021-09-30T08:28:45Z

eiffel-vocabulary/EiffelEnvironmentDefinedEvent.md

-| 3.2.0     | Current version                                        | Add links.domainId member (see [Issue 233](https://github.com/eiffel-community/eiffel/issues/233)). |
-| 3.1.0     | Current version                                        | Added RUNTIME_ENVIRONMENT link type. |
+| 3.2.0     | [edition-lyon](../../../tree/edition-lyon)             | Add links.domainId member (see [Issue 233](https://github.com/eiffel-community/eiffel/issues/233)). |
+| 3.1.0     | [edition-lyon](../../../tree/edition-lyon)             | Added RUNTIME_ENVIRONMENT link type. |


Same comment as for ActF

e-backmark-ericsson · 2021-09-30T08:29:20Z

eiffel-vocabulary/EiffelTestCaseFinishedEvent.md

-| 3.2.0     | Current version                                        | Add links.domainId member (see [Issue 233](https://github.com/eiffel-community/eiffel/issues/233)). |
-| 3.1.0     | Current version                                        | Add `data.persistentLogs.{mediaType,tags}`.   |
+| 3.2.0     | [edition-lyon](../../../tree/edition-lyon)             | Add links.domainId member (see [Issue 233](https://github.com/eiffel-community/eiffel/issues/233)). |
+| 3.1.0     | [edition-lyon](../../../tree/edition-lyon)             | Add `data.persistentLogs.{mediaType,tags}`.   |


Same comment as for ActF

e-backmark-ericsson · 2021-09-30T08:29:36Z

eiffel-vocabulary/EiffelTestCaseStartedEvent.md

-| 3.2.0     | Current version                                        | Add links.domainId member (see [Issue 233](https://github.com/eiffel-community/eiffel/issues/233)). |
-| 3.1.0     | Current version                                        | Add `data.liveLogs.{mediaType,tags}`.   |
+| 3.2.0     | [edition-lyon](../../../tree/edition-lyon)             | Add links.domainId member (see [Issue 233](https://github.com/eiffel-community/eiffel/issues/233)). |
+| 3.1.0     | [edition-lyon](../../../tree/edition-lyon)             | Add `data.liveLogs.{mediaType,tags}`.   |


Same comment as for ActF

e-backmark-ericsson · 2021-09-30T08:29:57Z

eiffel-vocabulary/EiffelTestExecutionRecipeCollectionCreatedEvent.md

-| 4.1.1     | Current version                                        | Add missing validation pattern to links.target member (see [Issue 271](https://github.com/eiffel-community/eiffel/issues/271)). |
-| 4.1.0     | Current version                                        | Add links.domainId member (see [Issue 233](https://github.com/eiffel-community/eiffel/issues/233)). |
+| 4.1.1     | [edition-lyon](../../../tree/edition-lyon)             | Add missing validation pattern to links.target member (see [Issue 271](https://github.com/eiffel-community/eiffel/issues/271)). |
+| 4.1.0     | [edition-lyon](../../../tree/edition-lyon)             | Add links.domainId member (see [Issue 233](https://github.com/eiffel-community/eiffel/issues/233)). |


Same comment as for ActF

e-backmark-ericsson · 2021-09-30T08:30:10Z

eiffel-vocabulary/EiffelTestSuiteFinishedEvent.md

-| 3.2.0     | Current version                                        | Add links.domainId member (see [Issue 233](https://github.com/eiffel-community/eiffel/issues/233)). |
-| 3.1.0     | Current version                                        | Add `data.persistentLogs.{mediaType,tags}`.   |
+| 3.2.0     | [edition-lyon](../../../tree/edition-lyon)             | Add links.domainId member (see [Issue 233](https://github.com/eiffel-community/eiffel/issues/233)). |
+| 3.1.0     | [edition-lyon](../../../tree/edition-lyon)             | Add `data.persistentLogs.{mediaType,tags}`.   |


Same comment as for ActF

e-backmark-ericsson · 2021-09-30T08:30:24Z

eiffel-vocabulary/EiffelTestSuiteStartedEvent.md

-| 3.2.0     | Current version                                        | Add links.domainId member (see [Issue 233](https://github.com/eiffel-community/eiffel/issues/233)). |
-| 3.1.0     | Current version                                        | Add `data.liveLogs.{mediaType,tags}`.   |
+| 3.2.0     | [edition-lyon](../../../tree/edition-lyon)             | Add links.domainId member (see [Issue 233](https://github.com/eiffel-community/eiffel/issues/233)). |
+| 3.1.0     | [edition-lyon](../../../tree/edition-lyon)             | Add `data.liveLogs.{mediaType,tags}`.   |


Same comment as for ActF

e-backmark-ericsson · 2021-09-30T08:41:39Z

Milestones are just containers of issues and PRs so it depends on how we want to use the milestones. So far the Lyon milestone has only contained issues and no PRs so to stick with that ad hoc convention we should leave this PR out (but add the #272 issue).

Ok. Fair enough. We should document our WoW around milestones - #279

magnusbaeck requested a review from a team September 28, 2021 15:20

t-persson previously approved these changes Sep 30, 2021

View reviewed changes

e-backmark-ericsson requested changes Sep 30, 2021

View reviewed changes

e-backmark-ericsson mentioned this pull request Sep 30, 2021

Document our WoW on milestones for the protocol #279

Closed

Prepare for release of Lyon

dd37957

magnusbaeck dismissed t-persson’s stale review via dd37957 October 8, 2021 14:01

magnusbaeck force-pushed the lyon branch from b370cb8 to dd37957 Compare October 8, 2021 14:01

magnusbaeck requested review from e-backmark-ericsson and t-persson October 8, 2021 14:03

t-persson approved these changes Oct 8, 2021

View reviewed changes

m-linner-ericsson approved these changes Oct 11, 2021

View reviewed changes

e-backmark-ericsson approved these changes Oct 11, 2021

View reviewed changes

e-backmark-ericsson merged commit 78b96a5 into eiffel-community:master Oct 12, 2021

magnusbaeck deleted the lyon branch October 15, 2021 11:02

magnusbaeck mentioned this pull request Oct 18, 2021

Update to Orizaba edition of protocol eiffel-community/eiffel-remrem-semantics#141

Closed

e-backmark-ericsson mentioned this pull request Nov 3, 2021

Add testCase version to TERCC batches #286

Merged

e-backmark-ericsson pushed a commit to e-backmark-ericsson/eiffel that referenced this pull request Apr 13, 2022

Prepare for release of Lyon (eiffel-community#277)

7e612e7

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prepare for release of Lyon #277

Prepare for release of Lyon #277

magnusbaeck commented Sep 28, 2021

e-backmark-ericsson commented Sep 30, 2021

magnusbaeck commented Sep 30, 2021

e-backmark-ericsson Sep 30, 2021

e-backmark-ericsson Oct 4, 2021

magnusbaeck Oct 4, 2021

e-backmark-ericsson Sep 30, 2021

e-backmark-ericsson Sep 30, 2021

e-backmark-ericsson Sep 30, 2021

e-backmark-ericsson Sep 30, 2021

e-backmark-ericsson Sep 30, 2021

e-backmark-ericsson Sep 30, 2021

e-backmark-ericsson Sep 30, 2021

e-backmark-ericsson commented Sep 30, 2021

	\| 3.1.0 \| [edition-lyon](../../../tree/edition-lyon) \| Add `data.persistentLogs.{mediaType,tags}`. \|
	\| 3.1.0 \| No edition set \| Add `data.persistentLogs.{mediaType,tags}`. \|

Prepare for release of Lyon #277

Prepare for release of Lyon #277

Conversation

magnusbaeck commented Sep 28, 2021

Applicable Issues

Description of the Change

Alternate Designs

Benefits

Possible Drawbacks

Sign-off

e-backmark-ericsson commented Sep 30, 2021

magnusbaeck commented Sep 30, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

e-backmark-ericsson commented Sep 30, 2021