Remove empty meta.source from ArtC example event #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The backend.json examples for ArtC contained an empty meta.source member. While technically okay it's uncalled for and can be confusing for readers. It can also cause problems for tests of code that use these examples as testdata.
e-backmark-ericsson
approved these changes
Oct 15, 2021
t-persson
approved these changes
Oct 22, 2021
magnusbaeck
added a commit
to magnusbaeck/eiffelevents-sdk-go
that referenced
this pull request
Oct 26, 2021
Now that eiffel-community/eiffel#284 has been merged all the examples in the protocol git work (and we obviously have to update the submodule link to point to that commit).
e-backmark-ericsson
pushed a commit
to e-backmark-ericsson/eiffel
that referenced
this pull request
Apr 13, 2022
The backend.json examples for ArtC contained an empty meta.source member. While technically okay it's uncalled for and can be confusing for readers. It can also cause problems for tests of code that use these examples as testdata.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applicable Issues
Fixes #283
Description of the Change
The backend.json examples for ArtC contained an empty meta.source member. While technically okay it's uncalled for and can be confusing for readers. It can also cause problems for tests of code that use these examples as testdata. See the associated issue for an elaboration.
Alternate Designs
None.
Benefits
Less confusion, less hassle for those using these examples for testing serialization code.
Possible Drawbacks
None.
Sign-off
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or
(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or
(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.
(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.
Signed-off-by: Magnus Bäck <magnus.back@axis.com>