Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!(types,rpc): Add share, row, merkle proofs and share.GetRange #375

Merged
merged 12 commits into from
Sep 19, 2024

Conversation

zvolin
Copy link
Member

@zvolin zvolin commented Sep 3, 2024

No description provided.

@zvolin zvolin requested review from oblique and fl0rek and removed request for oblique September 9, 2024 12:32
@zvolin zvolin marked this pull request as ready for review September 9, 2024 12:32
Cargo.toml Outdated Show resolved Hide resolved
Copy link
Member

@fl0rek fl0rek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice 🦀
Few comments, mostly nits in comments.

rpc/tests/share.rs Outdated Show resolved Hide resolved
types/src/data_availability_header.rs Outdated Show resolved Hide resolved
types/src/merkle_proof.rs Outdated Show resolved Hide resolved
types/src/merkle_proof.rs Outdated Show resolved Hide resolved
types/src/merkle_proof.rs Outdated Show resolved Hide resolved
types/src/share/proof.rs Outdated Show resolved Hide resolved
types/src/share/proof.rs Outdated Show resolved Hide resolved
types/src/share/proof.rs Outdated Show resolved Hide resolved
types/src/share/proof.rs Outdated Show resolved Hide resolved
zvolin and others added 4 commits September 19, 2024 11:33
Co-authored-by: Mikołaj Florkiewicz <mikolaj@florkiewicz.me>
Signed-off-by: Maciej Zwoliński <mac.zwolinski@gmail.com>
Copy link
Member

@oblique oblique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@fl0rek fl0rek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 🎸

@fl0rek fl0rek merged commit 36f1ceb into eigerco:main Sep 19, 2024
6 checks passed
@zvolin zvolin mentioned this pull request Sep 18, 2024
@zvolin zvolin deleted the feat/shares-range-rpc branch September 19, 2024 11:29
zvolin added a commit to fl0rek/celestia-node-rs that referenced this pull request Sep 20, 2024
…igerco#375)

Signed-off-by: Maciej Zwoliński <mac.zwolinski@gmail.com>
Co-authored-by: Mikołaj Florkiewicz <mikolaj@florkiewicz.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants