Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): fix double npm release by separating jobs #397

Conversation

zvolin
Copy link
Member

@zvolin zvolin commented Sep 26, 2024

No description provided.

@zvolin zvolin force-pushed the chore/fix-npm-double-releasing branch from d36cf85 to e803e92 Compare September 26, 2024 13:27
Copy link
Member

@fl0rek fl0rek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚙️

@zvolin zvolin changed the title chore(ci): fix double npm release by separating jobs chore(ci): fix double npm release by separating jobs DONT MERGE!!!! Sep 26, 2024
@zvolin zvolin changed the title chore(ci): fix double npm release by separating jobs DONT MERGE!!!! DONT MERGE!!!! chore(ci): fix double npm release by separating jobs Sep 26, 2024
@zvolin
Copy link
Member Author

zvolin commented Sep 26, 2024

Caution

we must coordinate it with next time we want to release, otherwise we'll try to publish 0.3.0 to npm again

@zvolin zvolin changed the base branch from main to release-plz-2024-10-03T12-05-23Z October 3, 2024 13:12
@zvolin zvolin changed the title DONT MERGE!!!! chore(ci): fix double npm release by separating jobs chore(ci): fix double npm release by separating jobs Oct 3, 2024
@zvolin
Copy link
Member Author

zvolin commented Oct 3, 2024

merging into release plz PR

@zvolin zvolin merged commit ba1f5b3 into eigerco:release-plz-2024-10-03T12-05-23Z Oct 3, 2024
6 checks passed
@zvolin zvolin deleted the chore/fix-npm-double-releasing branch October 3, 2024 13:12
@zvolin zvolin restored the chore/fix-npm-double-releasing branch October 3, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants