build(types): Use protox instead of requiring protoc when building #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@S1nus could you also update the build instructions in README, since protoc isn't needed anymore? I think it'll just be "# install dependencies" line |
zvolin
reviewed
Oct 1, 2024
zvolin
reviewed
Oct 1, 2024
zvolin
reviewed
Oct 1, 2024
Co-authored-by: Maciej Zwoliński <mac.zwolinski@gmail.com> Signed-off-by: c-node <chuckhead7@gmail.com>
Co-authored-by: Maciej Zwoliński <mac.zwolinski@gmail.com> Signed-off-by: c-node <chuckhead7@gmail.com>
fl0rek
reviewed
Oct 2, 2024
fl0rek
changed the title
oblique
reviewed
Oct 2, 2024
Co-authored-by: Yiannis Marangos <psyberbits@gmail.com> Signed-off-by: c-node <chuckhead7@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Easy way to remove the
protocbuild dependency is to use protox