Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add load exact method #314

Merged
merged 5 commits into from
Aug 6, 2024
Merged

Add load exact method #314

merged 5 commits into from
Aug 6, 2024

Conversation

digitalsadhu
Copy link
Member

@digitalsadhu digitalsadhu commented Aug 5, 2024

Makes it possible to pass an exact path to a config file (either package.json or eik.json) to the get-defaults method used in the cli commands. Non breaking backwards compatible change.

Part of the work needed to solve eik-lib/cli#553

This method makes it possible to load an exact config file from a given path instead of providing a directory for scanning
Copy link
Contributor

@leftieFriele leftieFriele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a nit pick on the one function, which isn't exposed through the API so it's no big deal.

lib/helpers/config-store.js Outdated Show resolved Hide resolved
digitalsadhu and others added 2 commits August 6, 2024 09:55
Co-authored-by: Espen Dalløkken <leftie.friele@gmail.com>
@digitalsadhu digitalsadhu merged commit bb949c0 into next Aug 6, 2024
4 checks passed
@digitalsadhu digitalsadhu deleted the add_load_exact_method branch August 6, 2024 03:00
Copy link

github-actions bot commented Aug 6, 2024

🎉 This issue has been resolved in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants