Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly manage Synapse configuration override #414

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Properly manage Synapse configuration override #414

wants to merge 1 commit into from

Conversation

ad2ien
Copy link
Member

@ad2ien ad2ien commented Apr 30, 2024 •
edited
Loading

Issue

#414

  • if password_config is to be false (users have to log in only through the provided ID providers) it needs to be configured so after the roles related to admin user : first-admin, discovery-rooms, synapse-extra-config, auth-buttons
  • sometimes, if Synapse configuration changes, it has to be redeployed

The idea

Let's add a variable that will re deploy Synapse from scratch (keeping the database unchanged).

  • the homeserver is configured once and subsequent deployments will be faster
  • We have a way to change the configuration without meeting any configuration override issues

@ad2ien ad2ien force-pushed the fix/synapse-password-config branch from b7b124f to 6499427 Compare April 30, 2024 16:00
@ad2ien ad2ien self-assigned this Apr 30, 2024
@ad2ien ad2ien requested a review from heroinedor April 30, 2024 16:05
@ad2ien ad2ien marked this pull request as ready for review April 30, 2024 16:05
@ad2ien ad2ien marked this pull request as draft May 2, 2024 07:02
@ad2ien ad2ien force-pushed the fix/synapse-password-config branch from 6499427 to 4638f82 Compare May 7, 2024 16:42
@ad2ien ad2ien marked this pull request as ready for review May 13, 2024 09:54
@ad2ien ad2ien changed the title fix(synapse): configure password_config after using admin user Properly manage Synapse configuration override May 13, 2024
@ad2ien ad2ien force-pushed the fix/synapse-password-config branch from 4638f82 to 0e41ba1 Compare May 15, 2024 07:38
@ad2ien ad2ien marked this pull request as draft May 16, 2024 08:35
@ad2ien
Copy link
Member Author

ad2ien commented May 16, 2024 •
edited
Loading

Review with @heroinedor

  • Make discovery room role optional
  • create admin with Synapse script
  • The best way would be to find a way to upload pictos and avoid extraconfig step so we don't need admin login

@ad2ien ad2ien force-pushed the fix/synapse-password-config branch 2 times, most recently from 9ff7b1f to 9f970cd Compare June 5, 2024 09:38
@ad2ien ad2ien force-pushed the fix/synapse-password-config branch from 9f970cd to 21eacf2 Compare June 12, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heroinedor heroinedor Awaiting requested review from heroinedor

Assignees

@ad2ien ad2ien

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ad2ien