Improve date handling #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove references to relative cubism-es use the one in the 3rd party folder instead. Ensure that the version is bumped. Signed-off-by: Matthieu Patou <mat@matws.net>
Let's have a prometheus datasource and csv one. For the CSV we will also add CSV file inside the container
With devtools set to `source-map` and mode to `production` it's impossible as of April 2024 to add breakpoints in both firefox and chrome. It does lead to a somewhat small file but at the cost of debugability. When using `eval-source-map` for devtools no matter what is the mode you can properly debug but the resulting file is fairly large (800K). Finally using mode `development` allows to debug and the resulting file is "only" twice as large so we will settle on that. Signed-off-by: Matthieu Patou <mat@matws.net>
Previous to this change the plugin assumed that the date should be displayed in the timezone of the browser no matter what was the setting. Also it wouldn't deal with the timerange that was specified (sic). This is fixed in this change now, we leverage `serverDelay` to send the metrics back in time by providing a positive delay and forward in time (in case the selected timezone is ahead of time) by providing a negative delay.
ekacnet
force-pushed
the
improve_date_handling
branch
from
0f9abc7
to
fee47d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous to this change the plugin assumed that the date should be
displayed in the timezone of the browser no matter what was the setting.
Also it wouldn't deal with the timerange that was specified (sic).
This is fixed in this change now, we leverage
serverDelayto send themetrics back in time by providing a positive delay and forward in time
(in case the selected timezone is ahead of time) by providing a negative
delay.