Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of pipes #341

Closed
bersbersbers opened this issue Aug 30, 2023 · 3 comments · Fixed by #342
Closed

Remove usage of pipes #341

bersbersbers opened this issue Aug 30, 2023 · 3 comments · Fixed by #342

Comments

@bersbersbers
Copy link

I am getting

C:\Python\Lib\site-packages\nodeenv.py:26: DeprecationWarning: 'pipes' is deprecated and slated for removal in Python 3.13

due to

nodeenv/nodeenv.py

Line 26 in 4ae75e3

import pipes

@bersbersbers
Copy link
Author

Just came across another one:

pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html

@eccles
Copy link

eccles commented Oct 18, 2023

Same here - this occurred when I attempted to add support for python 3.12:

task: [check] ./scripts/builder.sh python3 -m pyright --stats archivist
/usr/local/lib/python3.12/site-packages/nodeenv.py:26: DeprecationWarning: 'pipes' is deprecated and slated for removal in Python 3.13
import pipes
/usr/local/lib/python3.12/site-packages/nodeenv.py:48: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html
from pkg_resources import parse_version

  • Install prebuilt node (21.0.0) .

The 'Install prebuilt node..' hangs forever

eccles added a commit to datatrails/datatrails-python that referenced this issue Oct 18, 2023
@eccles
Support for python 3.12
3573ded 
Upgrade all dependencies that support python 3.8-3.12.
Disable pyright for 3.12 as it is currently incompatible.
(ekalinin/nodeenv#341)

AB#8633
@eccles eccles mentioned this issue Oct 18, 2023
Merged
musicinmybrain added a commit to musicinmybrain/nodeenv that referenced this issue Oct 23, 2023
@musicinmybrain
On Python 3.3+, replace pipes.quote with shlex.quote
d20e14f 
The pipes.quote() function was undocumented, and the pipes module was
deprecated in Python 3.11 and will be removed in Python 3.13.

Fixes ekalinin#341.
@musicinmybrain musicinmybrain mentioned this issue Oct 23, 2023
Merged
eccles added a commit to datatrails/datatrails-python that referenced this issue Nov 3, 2023
@eccles
Support for python 3.12 (#249)
0b32dbb 
Upgrade all dependencies that support python 3.8-3.12.
Disable pyright for 3.12 as it is currently incompatible.
(ekalinin/nodeenv#341)

AB#8633
@neutrinoceros neutrinoceros mentioned this issue Nov 4, 2023
Closed
@rffontenelle
Copy link

FWIW, it is deprecated since Python 3.11 and the subprocess module is the recommended as replacement

ekalinin pushed a commit that referenced this issue May 28, 2024
@musicinmybrain
On Python 3.3+, replace pipes.quote with shlex.quote (#342)
c1dffc5 
* On Python 3.3+, replace pipes.quote with shlex.quote

The pipes.quote() function was undocumented, and the pipes module was
deprecated in Python 3.11 and will be removed in Python 3.13.

Fixes #341.

* Choose shlex or pipes based on Python version

It was pointed out that pyupgrade can handle this better than
try/except.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@eccles @rffontenelle @bersbersbers