-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pelagios API link broken (priority: Hestia critical) #29
Comments
Added more to the JSON so the gazetteer URI is present. That should be used http://gap2.alexandriaarchive.org/places/613/books.json On Thu, Apr 17, 2014 at 7:21 AM, atomrab notifications@github.com wrote:
|
I observed that both features work with the gap version of the tool http://enridaga.github.io/gapvis/gap . The reason is that, while the gap api uses the pelagios id as reference id for places, hestia data don't, the hestia api uses a different id. This is not a major issue, but we need to adapt the tool to use the "uri" of the place instead of the "id" to build links to pleiades, and to build the query to get flikr images. I opened enridaga/gapvis#25 and enridaga/gapvis#26 to track the implementations. |
Both links to pelagios and flickr images also work on Hestia too. |
I think this is probably an easy fix. While the link to Pleiades in the place details page works fine, the link to Pelagios queries not the Pleiades URI place-number, but whatever internal number has been assigned to the same place in Hestia/Gapvis. Thus, with Argos, the Pleiades link goes to http://pleiades.stoa.org/places/570106 (correctly), but the Pelagios link goes to http://pelagios.dme.ait.ac.at/api/places/http%3A%2F%2Fpleiades.stoa.org%2Fplaces%2F336 -- with "336" also being at the end of the page URL (http://enridaga.github.io/gapvis/gap2/#book/1/place/336). This returns the message "Place http://pleiades.stoa.org/places/336 not found". The Pleiades ID is clearly being lost in translation (and if it is repaired, would we get the Flickr images at the bottom, too?).
The text was updated successfully, but these errors were encountered: