Fix the build for Linux ARM64 #99
Conversation
This should fix the failing tests: ``` ok 1 - seqwish prints its help ==5145==LeakSanitizer has encountered a fatal error. ==5145==HINT: For debugging, try setting environment variable LSAN_OPTIONS=verbosity=1:log_threads=1 ==5145==HINT: LeakSanitizer does not work under ptrace (strace, gdb, etc) not ok 2 - unnamed test # got: 'f82bea6331f62e86cce543c36fb4c1f6' # expected: 'seqwish correctly builds the graph for A-3105' ==5170==LeakSanitizer has encountered a fatal error. ==5170==HINT: For debugging, try setting environment variable LSAN_OPTIONS=verbosity=1:log_threads=1 ==5170==HINT: LeakSanitizer does not work under ptrace (strace, gdb, etc) ```
|
Any feedback on the suggested changes ? |
|
First, it's awesome. Second, I'm not sure that I need to test before merging, but it looks good. |
|
Good job, @julien-faye ! |
|
Just did some quick tests and this looks good to go! Thank you! |
|
Awesome! |
|
Unfortunately, I now can't build (apparently due to the drop of the compare and swap compiler option): How should we resolve this? |
|
Weirdly, I can build on one system, but not another. On both, I'm using GCC 11 and have x86_64. On one I'm building in guix. |
|
Hi @ekg ! You will need to pass I can send a new PR to make CMakeLists.txt more x86_64 friendly, i.e. this flag to be added by default if the user hasn't provided explicitly |
|
It looks like the problem was with guix! So no issues here. |
Pass '-mcx16' as a CMake option only for x86_64.
Run the build and tests in a Docker container for ARM64. Do not use sanitizers because they are not usable without ptrace (in container).