Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep sync with .gitmodules #16

Merged
merged 1 commit into from
Mar 29, 2018
Merged

Keep sync with .gitmodules #16

merged 1 commit into from
Mar 29, 2018

Conversation

Munsen
Copy link
Contributor

@Munsen Munsen commented Mar 28, 2018

#14 just sync before update submodule

1st8
1st8 approved these changes Mar 29, 2018
View reviewed changes
Copy link
Collaborator

@1st8 1st8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes complete sense to me, albeit I had a few beers... 😄
Maybe I haven't added submodules in a while.

@ekho ekho merged commit d1a85bf into ekho:master Mar 29, 2018
@1st8
Copy link
Collaborator

1st8 commented Mar 29, 2018 •
edited
Loading

Cheers @ekho and @Munsen 🍻

@Munsen Munsen deleted the feature/sync-before-update branch March 29, 2018 17:01
@samuelgiles
Copy link

@1st8 Will this form a 2.0.4 release at any point?

@1st8
Copy link
Collaborator

1st8 commented Jun 3, 2020

It probably should. Could you bump the version @ekho ?

@ekho
Copy link
Owner

ekho commented Jun 3, 2020 •
edited
Loading

@1st8 have you an account at rubygems.org ?

@ekho
Copy link
Owner

ekho commented Jun 3, 2020

Version bumped to 2.0.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st8 1st8 1st8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Munsen @1st8 @samuelgiles @ekho