Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/try update before sync #17

Merged
merged 2 commits into from
Mar 21, 2022
Merged

Bugfix/try update before sync #17

merged 2 commits into from
Mar 21, 2022

Conversation

Munsen
Copy link
Contributor

@Munsen Munsen commented Apr 13, 2018 •
edited
Loading

#14 I am not sure this is the right way to fix. but this perfectly works for me.

git submodule sync --recursive update repo/config well. but it doesn't update repo/modules/<submodule>/config

I found out that repo/modules/submodule/config has updated git submodule sync after git submodule update even git submodule update failed

@Munsen
Fix git submodule sync change repo/modules/<submodule>/config
8efa139 
`submodule sync` has not affect repo/modules/<submodule>/config
it only affect on `repo/config`.

should `submodule update` before `submodule sync` to update
repo/modules/<submodule>/config even it failed
@Munsen Munsen force-pushed the bugfix/try-update-before-sync branch from 96c201f to 8efa139 Compare April 13, 2018 09:55
ekho
ekho approved these changes Mar 21, 2022
View reviewed changes
Copy link
Owner

@ekho ekho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ekho ekho merged commit 43faf22 into ekho:master Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekho ekho ekho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Munsen @ekho