add-to-update-remote-fetch #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added remote fetch so that actual latest commit gets fetched from remote
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having some issues with not getting the latest commit from origin, was getting an earlier commit (I expected that I would also get the HEAD in remote from submodule origins). Somehow even after updating local to the latest commit the commands in ruby give the same
Turns out that according to SO this is normal, and you have to do extra work to get the submodules updated to the remote version.
I saw the note in the contributing section about adding tests, however I am a Ruby noob and I saw that other PRs don't have tests, so I have not added. If you can add some info about how to mock a git remote then I can try 🙏
I tested the change on my Portfolio website by adding my fork in the Gemfile and it looks like it worked for that implementation