Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reading from DBF to DataTable #38

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Add reading from DBF to DataTable #38

wants to merge 13 commits into from

Conversation

plmmihail
Copy link
Contributor

With original names of columns and simple types of columns, NULL-safe.

@plmmihail
Add reading from DBF to DataTable
d56a42e 
With original names of columns and simple types of columns, NULL-safe.
jbtule
jbtule requested changes Mar 4, 2021
View reviewed changes
Copy link
Member

@jbtule jbtule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks like a useful feature. Just needs to take into account existing features.

DotNetDBF/DBFReader.cs Outdated Show resolved Hide resolved
DotNetDBF/DBFReader.cs Outdated Show resolved Hide resolved
DotNetDBF/DBFReader.cs Outdated Show resolved Hide resolved
plmmihail and others added 3 commits March 5, 2021 09:49
@plmmihail plmmihail mentioned this pull request Mar 9, 2021
Open
@plmmihail
Copy link
Contributor Author

@jbtule , all problems are resolved and #36 is ready

@plmmihail plmmihail requested a review from jbtule March 16, 2021 09:25
@plmmihail
Add auto selection of all fields
7422453 
And function for selecting of all fields
jbtule
jbtule requested changes Mar 22, 2021
View reviewed changes
DotNetDBF/DBFReader.cs Outdated Show resolved Hide resolved
@plmmihail plmmihail requested a review from jbtule March 23, 2021 09:31
jbtule
jbtule requested changes Mar 23, 2021
View reviewed changes
Copy link
Member

@jbtule jbtule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just typed this into the review, might need some fixing, but should give the idea of what needs to change.

DotNetDBF/DBFReader.cs Outdated Show resolved Hide resolved
DotNetDBF/DBFReader.cs Outdated Show resolved Hide resolved
DotNetDBF/DBFReader.cs Outdated Show resolved Hide resolved
DotNetDBF/DBFReader.cs Outdated Show resolved Hide resolved
DotNetDBF/DBFReader.cs Outdated Show resolved Hide resolved
DotNetDBF/DBFReader.cs Outdated Show resolved Hide resolved
plmmihail and others added 7 commits March 24, 2021 10:28
@plmmihail @jbtule
DBFReader.cs, SelectAllFields()
7e84a8b 
Formatting SelectAllFields()

Co-authored-by: Jay Tuley <jay@tuley.name>
@plmmihail @jbtule
DBFReader.cs _selectFields.Length
e5f404e 
Formatting _selectFields.Length

Co-authored-by: Jay Tuley <jay@tuley.name>
@plmmihail @jbtule
DBFReader.cs Simple NextRecord(); 1
c75b545 
Simplification of NextRecord(); call

Co-authored-by: Jay Tuley <jay@tuley.name>
@plmmihail @jbtule
DBFReader.cs Simple NextRecord(); 2
a269ed2 
Simplification of NextRecord(); call

Co-authored-by: Jay Tuley <jay@tuley.name>
@plmmihail @jbtule
DBFReader.cs value cycle
8c59e5b 
Preparing DataTable value cycle for a rare types of fileds like  Memo or OLE.

Co-authored-by: Jay Tuley <jay@tuley.name>
@plmmihail @jbtule
DBFReader.cs ReadAllToDataTable
033f9eb 
Remaning ReadDataTable

Co-authored-by: Jay Tuley <jay@tuley.name>
@plmmihail
DataTableReader style changes
a176ead
@plmmihail plmmihail requested a review from jbtule March 24, 2021 09:37
@plmmihail
Copy link
Contributor Author

Ping, @jbtule !

1 similar comment
@plmmihail
Copy link
Contributor Author

Ping, @jbtule !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbtule jbtule Awaiting requested review from jbtule

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@plmmihail @jbtule