Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move functions from eks.go #5810

Closed

Conversation

shogohida
Copy link

@shogohida shogohida commented Oct 24, 2022

Description

Fixes #5482

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello shogohida 👋 Thank you for opening a Pull Request in eksctl project. The team will review the Pull Request and aim to respond within 1-5 business days. Meanwhile, please read about the Contribution and Code of Conduct guidelines here. You can find out more information about eksctl on our website

@Himangini Himangini mentioned this pull request Oct 25, 2022
7 tasks
@shogohida shogohida force-pushed the move-functions-from-eks.go branch from 4387475 to 9d42f8f Compare October 27, 2022 02:26
@shogohida shogohida marked this pull request as ready for review October 27, 2022 02:28
@github-actions github-actions bot added the stale label Nov 27, 2022
@github-actions github-actions bot closed this Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Refactor eks.go
1 participant