Add eksctl drain nodegroup

[errordeveloper]

Description

Add eksctl drain nodegroup [--undo].

Towards #370.

Next I'm going to refactor this more and add it to eksctl delete nodegroup, but in another PR.

Checklist

• Code compiles correctly (i.e make build)
• All unit tests passing (i.e. make test)
• All integration tests passing (i.e. make integration-test)
• Added/modified documentation as required (such as the README.md, and examples directory)

[whereisaaron]

"Uncordon"

[whereisaaron]

Probably too late to comment, but --undo isn't very explanatory and you are not really undoing the drain. Maybe better just to have eksctl cordon nodegroup and eksctl uncordon nodegroup, which are useful in themselves. And rather than running eksctl drain nodegroup --undo users would run eksctl uncordon nodegroup to achieve the same thing?

[errordeveloper]

Thanks, good idea! This was kind of an afterthought. I'll have a look tomorrow, and seen what can be changed - we didn't roll this into a release yet.

…

On Thu, 28 Feb 2019, 5:48 pm Aaron Roydhouse, ***@***.***> wrote: Probably too late to comment, but --undo isn't very explanatory and you are not really undoing the drain. Maybe better just to have eksctl cordon nodegroup and eksctl uncordon nodegroup, which are useful in themselves. And ran than running eksctl drain nodegroup --undo users would run eksctl uncordon nodegroup to achieve the same thing? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#592 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAPWS0U2EJnx0DAQfLfwuOwncNlmATbXks5vSBZ8gaJpZM4bWvFj> .