Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outlook #16

Open
throrin19 opened this issue Sep 13, 2016 · 9 comments
Open

Outlook #16

throrin19 opened this issue Sep 13, 2016 · 9 comments

Comments

@throrin19
Copy link

Hi,

I've test your library into oulook and the result is not great :(. The icon size in the header is incorrect and the button in the body is not visible as you can see in the bellow screen :

capture

@eladnava
Copy link
Owner

eladnava commented Sep 13, 2016

Hi @throrin19,
Thanks for the report!

Is this happening in the default Mailgen theme? What version of Outlook?

@throrin19
Copy link
Author

It's an extension of the default theme with only the header background and text color changed.

For outlook, it's the version 2016

@eladnava
Copy link
Owner

@throrin19 Could you try sending with other themes? E.g. salted or cerberus?

@throrin19
Copy link
Author

I've test with the original theme and the neopolitan theme and this is the result :

capture 1
capture 2

In the default theme, the button is not visible and, in the neopolitan theme, Outlook seems to add text decoration in the <a> tag

@throrin19
Copy link
Author

OK I found problems.

For the logo : Outlook >=2013 only support images with the width setted directly like that :

<-- This image will be resized to 300px in Outlook -->
<img src="https://www.emailonacid.com/images/photo.jpg" width="300" style="width:300px;" />

<-- This image will NOT be resized in Outlook -->
<img src="https://www.emailonacid.com/images/photo.jpg" style="width:300px;" />

For the button, it's more complexe. I remove the mso-hide in the .button section bug outlook don't show it correctly. So, after many research and tests, we should add specific tag for outloock like this gist :

https://gist.github.com/elidickinson/9424116#file-html_email_buttons_1-html

I think you should update your templates to work correctly in MS outlook desktop app

@eladnava
Copy link
Owner

Ooh, that doesn't look pretty.

We could use a service like Litmus to fix this (previewing the themes in the most popular e-mail clients without having to install them). They have a 3-day free trial which could suffice.

If you have the time, would you like to submit a PR to add compatibility for Outlook?

@throrin19
Copy link
Author

I make that ASAP

@eladnava
Copy link
Owner

eladnava commented Oct 10, 2016

@throrin19 Please comment if you still intend to work on this, otherwise, this is up for grabs. 👍

@charlie-s
Copy link
Contributor

I added a comment to https://gist.github.com/elidickinson/9424116 that centers the button and changed the default template to support the button method. I'll work on the logo in a separate merge request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants