-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Outlook #16
Comments
Hi @throrin19, Is this happening in the |
It's an extension of the default theme with only the header background and text color changed. For outlook, it's the version 2016 |
@throrin19 Could you try sending with other themes? E.g. |
OK I found problems. For the logo : Outlook >=2013 only support images with the width setted directly like that :
For the button, it's more complexe. I remove the https://gist.github.com/elidickinson/9424116#file-html_email_buttons_1-html I think you should update your templates to work correctly in MS outlook desktop app |
Ooh, that doesn't look pretty. We could use a service like Litmus to fix this (previewing the themes in the most popular e-mail clients without having to install them). They have a 3-day free trial which could suffice. If you have the time, would you like to submit a PR to add compatibility for Outlook? |
I make that ASAP |
@throrin19 Please comment if you still intend to work on this, otherwise, this is up for grabs. 👍 |
I added a comment to https://gist.github.com/elidickinson/9424116 that centers the button and changed the default template to support the button method. I'll work on the logo in a separate merge request. |
Hi,
I've test your library into oulook and the result is not great :(. The icon size in the header is incorrect and the button in the body is not visible as you can see in the bellow screen :
The text was updated successfully, but these errors were encountered: