Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use v:roundrect for actionItems in Outlook. #34

Merged
merged 3 commits into from
Jan 3, 2019

Conversation

charlie-s
Copy link
Contributor

See #16 for relevant conversation. I made as minor changes as possible.

See screenshots in Chrome + Outlook 2013 below. Let me know if you have any concerns.

screen shot 2018-12-31 at 6 27 23 pm

screen shot 2018-12-31 at 6 27 38 pm

@eladnava
Copy link
Owner

eladnava commented Jan 2, 2019

Hi @charlie-s,
Thanks so much for this contribution! 😄

Any chance you would be willing to apply this fix to all four mailgen themes?

These are:

  • default
  • neopolitan
  • salted
  • cerberus

Thanks again! 👍

@charlie-s
Copy link
Contributor Author

charlie-s commented Jan 2, 2019 via email

@charlie-s
Copy link
Contributor Author

See latest commit for Cerberus. BTW – is this Cerberus pulled from https://github.com/TedGoas/Cerberus?

Neopolitan already uses v:roundrect to add round borders to its actionItems.

Salted's code is a little different and so I've left it alone. It uses large borders to achieve a button look (instead of padding) and they render fine in Outlook, albeit without rounded corners. Since they're legible, and there are many other issues for Salted in Outlook, it's probably best handled separately if someone uses it. Would you agree?

@eladnava eladnava merged commit ff76e51 into eladnava:master Jan 3, 2019
@eladnava
Copy link
Owner

eladnava commented Jan 3, 2019

Hi @charlie-s,
Sounds great! 💯 Well done mate.

Agree on what you said. Yes, it's the same Cerberus theme you linked.

Merged and published in 2.0.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants