Skip to content
This repository has been archived by the owner on Apr 12, 2022. It is now read-only.

Fix unhold issue with custom deb packages #146

Merged
merged 5 commits into from
May 26, 2021
Merged

Conversation

jmlrt
Copy link
Member

@jmlrt jmlrt commented May 20, 2021

This commit fix an issue where unholding package fails when using a
custom package url instead of Elastic repository and beat package isn't
installed yet.

Also replace apt-mark shell commands by dpkg_selections module.

Fix #83

This commit fix an issue where unholding package fails when using a
custom package url instead of Elastic repository and beat package isn't
installed yet.

Also replace `apt-mark` shell commands by `dpkg_selections` module.

Fix elastic#83
@jmlrt jmlrt added the bug label May 20, 2021
@jmlrt jmlrt requested a review from a team May 20, 2021 17:13
Conky5
Conky5 previously approved these changes May 24, 2021
Copy link

@Conky5 Conky5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This is require to fix idempotence test.
@jmlrt jmlrt requested a review from Conky5 May 25, 2021 10:04
@jmlrt jmlrt merged commit a8c66c4 into elastic:master May 26, 2021
@jmlrt jmlrt deleted the fix-unhold-deb branch May 26, 2021 04:35
@elasticmachine elasticmachine mentioned this pull request Jun 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error during "unhold filebeat version for install"
2 participants