Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updatecli: dynamic specs #1570

Merged
merged 4 commits into from
Jan 29, 2024
Merged

updatecli: dynamic specs #1570

merged 4 commits into from
Jan 29, 2024

Conversation

v1v
Copy link
Member

@v1v v1v commented Jan 25, 2024

What does this PR do?

Test

I iterated in the existing GitHub action by using the upstream branch:

Locally:

GITHUB_WORKSPACE=/tmp \
  PATH=/opt/homebrew/bin:$PATH \
  GIT_USER="Victor Martinez" \
  GIT_EMAIL="VictorMartinezRubio@gmail.com" \
  GITHUB_TOKEN=$(gh auth token) \
  updatecli apply --config .ci/updatecli/updatecli.d --values .ci/updatecli/values.yml --debug

or without pushing any changes

GITHUB_WORKSPACE=/tmp \
  PATH=/opt/homebrew/bin:$PATH \
  GIT_USER="Victor Martinez" \
  GIT_EMAIL="VictorMartinezRubio@gmail.com" \
  GITHUB_TOKEN=$(gh auth token) \
  updatecli apply --config .ci/updatecli/updatecli.d --values .ci/updatecli/values.yml --push=false --debug

additionally, you can change the org from elastic to your own GitHub avatar.

@v1v v1v requested a review from a team as a code owner January 25, 2024 09:12
@v1v v1v requested a review from a team January 25, 2024 09:12
@v1v v1v self-assigned this Jan 25, 2024
reakaleek
reakaleek previously approved these changes Jan 25, 2024
@v1v v1v enabled auto-merge (squash) January 25, 2024 11:00
@v1v v1v merged commit 72a8896 into main Jan 29, 2024
14 checks passed
@dmathieu dmathieu deleted the feature/updatecli-dynamic branch January 29, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants