Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily ignore folders that are not actual modules in coverage check #1579

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

dmathieu
Copy link
Member

The coverage check is currently broken because of golang/go#65653.

This change fixes the CI test by ignoring packages which aren't publicly available within -coverpkg.
This is a temporary fix, and we should revert this PR once the Go fix lands, either in 1.23, or with the cherry-pick for 1.22 in golang/go#66137.

@dmathieu dmathieu marked this pull request as ready for review March 11, 2024 10:12
@dmathieu dmathieu requested a review from a team as a code owner March 11, 2024 10:12
@dmathieu dmathieu enabled auto-merge (squash) March 11, 2024 10:15
@dmathieu dmathieu merged commit 8dd1587 into main Mar 11, 2024
14 checks passed
@dmathieu dmathieu deleted the fix-coverage branch March 11, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants